Inline cadmin project criteria query

Author: alexeygrigorev

cadmin/views/project_submission_edit.py

@@ -52,12 +52,6 @@ def project_submission_edit_objects(
     )
 
 
-def project_review_criteria(course):
-    criteria = ReviewCriteria.objects.filter(course=course)
-    ordered_criteria = criteria.order_by("id")
-    return ordered_criteria
-
-
 def project_evaluation_score_map(submission):
     scores = ProjectEvaluationScore.objects.filter(submission=submission)
     score_map = {}
@@ -115,7 +109,8 @@ def handle_project_submission_edit_post(data):
 
 
 def project_submission_edit_page_data(request, edit_objects):
-    review_criteria = project_review_criteria(edit_objects.course)
+    criteria = ReviewCriteria.objects.filter(course=edit_objects.course)
+    review_criteria = criteria.order_by("id")
     criteria_with_scores = criteria_with_project_scores(
         review_criteria,
         edit_objects.submission,

docs/refactoring-plan.md

@@ -5141,6 +5141,19 @@ Steps:
   `wide_positional_calls=0`, `wide_function_args=0`,
   `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
   `git diff --check`.
+- [x] 2026-07-02: Removed the single-use cadmin project edit review-criteria
+  queryset helper. The page-data builder now names the filtered criteria
+  queryset and ordering directly before attaching project scores. Verification:
+  `uv run ruff check cadmin/views/project_submission_edit.py docs/refactoring-plan.md`,
+  `python -m py_compile cadmin/views/project_submission_edit.py`,
+  `uv run python manage.py test cadmin.tests.test_project_submission_edit_views`,
+  removed-helper reference scan, touched-function line-threshold scan,
+  `uvx pyrefly check`, repository AST cleanup scan excluding migrations
+  (`forbidden_comprehensions=0`, `threshold_violations=0`,
+  `append_constructed=0`, `wide_tuple_unpacking=0`,
+  `wide_positional_calls=0`, `wide_function_args=0`,
+  `nested_wide_for_unpacking=0`, `range_len_loops=0`), and
+  `git diff --check`.
 - [x] 2026-07-02: Removed the single-use timezone preference save helper. The
   timezone update view now assigns and saves `user.preferred_timezone` directly
   in the successful update branch, while validation and response helpers remain