Skip to content

Commit 822ea3e

Browse files
committed
ci: Fix smoke test config keys to match actual flapi schema
- Use access_mode/max_memory (underscores) not hyphens - Remove db-path (use in-memory DB like integration tests) - Remove server.port section, pass port via -p flag - Add --config-service-token to match how integration tests invoke the binary - Add mcp.enabled: false to keep config minimal The bad config keys caused an immediate abort (before any log output) on all platforms, masking whether the real #20 crash also exists.
1 parent 2f25366 commit 822ea3e

1 file changed

Lines changed: 23 additions & 24 deletions

File tree

.github/workflows/build.yaml

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -353,19 +353,19 @@ jobs:
353353
template:
354354
path: ./sqls
355355
duckdb:
356-
db-path: ./smoke-test.duckdb
357-
access-mode: READ_WRITE
356+
access_mode: READ_WRITE
358357
threads: 1
359-
max-memory: 256MB
360-
server:
361-
port: 18080
358+
max_memory: 256MB
359+
mcp:
360+
enabled: false
362361
run: |
363362
cd smoke
364363
chmod +x flapi
365364
mkdir -p sqls
366365
printf '%s' "$SMOKE_CONFIG" > smoke-config.yaml
367366
368-
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml --config-service \
367+
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml -p 18080 \
368+
--config-service --config-service-token smoke-test \
369369
> server.log 2>&1 &
370370
FLAPI_PID=$!
371371
@@ -404,19 +404,19 @@ jobs:
404404
template:
405405
path: ./sqls
406406
duckdb:
407-
db-path: ./smoke-test.duckdb
408-
access-mode: READ_WRITE
407+
access_mode: READ_WRITE
409408
threads: 1
410-
max-memory: 256MB
411-
server:
412-
port: 18080
409+
max_memory: 256MB
410+
mcp:
411+
enabled: false
413412
run: |
414413
cd smoke
415414
chmod +x flapi
416415
mkdir -p sqls
417416
printf '%s' "$SMOKE_CONFIG" > smoke-config.yaml
418417
419-
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml --config-service \
418+
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml -p 18080 \
419+
--config-service --config-service-token smoke-test \
420420
> server.log 2>&1 &
421421
FLAPI_PID=$!
422422
@@ -455,19 +455,19 @@ jobs:
455455
template:
456456
path: ./sqls
457457
duckdb:
458-
db-path: ./smoke-test.duckdb
459-
access-mode: READ_WRITE
458+
access_mode: READ_WRITE
460459
threads: 1
461-
max-memory: 256MB
462-
server:
463-
port: 18080
460+
max_memory: 256MB
461+
mcp:
462+
enabled: false
464463
run: |
465464
cd smoke
466465
chmod +x flapi
467466
mkdir -p sqls
468467
printf '%s' "$SMOKE_CONFIG" > smoke-config.yaml
469468
470-
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml --config-service \
469+
DATAZOO_DISABLE_TELEMETRY=1 ./flapi -c smoke-config.yaml -p 18080 \
470+
--config-service --config-service-token smoke-test \
471471
> server.log 2>&1 &
472472
FLAPI_PID=$!
473473
@@ -506,12 +506,11 @@ jobs:
506506
template:
507507
path: ./sqls
508508
duckdb:
509-
db-path: ./smoke-test.duckdb
510-
access-mode: READ_WRITE
509+
access_mode: READ_WRITE
511510
threads: 1
512-
max-memory: 256MB
513-
server:
514-
port: 18080
511+
max_memory: 256MB
512+
mcp:
513+
enabled: false
515514
shell: pwsh
516515
run: |
517516
New-Item -ItemType Directory -Force smoke\sqls | Out-Null
@@ -520,7 +519,7 @@ jobs:
520519
$env:DATAZOO_DISABLE_TELEMETRY = "1"
521520
$p = Start-Process `
522521
-FilePath "smoke\flapi.exe" `
523-
-ArgumentList @("-c", "smoke-config.yaml", "--config-service") `
522+
-ArgumentList @("-c", "smoke-config.yaml", "-p", "18080", "--config-service", "--config-service-token", "smoke-test") `
524523
-WorkingDirectory smoke `
525524
-RedirectStandardOutput smoke\stdout.log `
526525
-RedirectStandardError smoke\stderr.log `

0 commit comments

Comments
 (0)