Commit 961b7fb
authored
fix(ci): make @flapi/shared build standalone so the clients gate is green (#88)
* fix(ci): make @flapi/shared build standalone so the clients gate passes
The clients CI workflow built @flapi/shared in isolation and failed two ways,
both masked locally by dependency hoisting from cli/node_modules:
- shared/src imported axios-retry, boxen, camelcase, chalk, cli-table3,
colorette, figures, lodash.kebabcase, log-symbols, ora and node builtins,
but shared/package.json only declared axios + js-yaml. Declare the real deps
(+ @types/node, @types/js-yaml).
- shared had no tsup.config, so tsup walked up to cli/tsup.config.ts and could
not resolve tsup from the empty cli/ in CI. Add shared/tsup.config.ts.
Verified by building shared with cli/node_modules removed (true CI isolation).
* fix(ci): make the VSCode extension build standalone
The extension relied on axios being hoisted from cli/node_modules; in the
isolated CI job it failed to resolve 'axios' and cascaded into implicit-any /
strict errors.
- Source the AxiosInstance type from @flapi/shared (the single canonical axios)
in the 8 type-only importers, avoiding a dual-axios type clash.
- Declare axios as a direct dependency for endpointTestService, which calls
axios() at runtime, and coerce its broad header value types to string.
Verified by typechecking/building/testing the extension with cli/node_modules
removed (true CI isolation).1 parent d245844 commit 961b7fb
15 files changed
Lines changed: 987 additions & 31 deletions
File tree
- .github/workflows
- cli
- vscode-extension
- src
- codelens
- editors
- explorer
- providers
- services
- webview
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
5 | 9 | | |
6 | 10 | | |
7 | 11 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
54 | 63 | | |
55 | 64 | | |
56 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
57 | 71 | | |
58 | 72 | | |
59 | 73 | | |
| |||
0 commit comments