Fix CI and improve contribute instructions#123
Merged
Conversation
arielj
force-pushed
the
fix-ci-not-bundling
branch
from
July 7, 2025 16:49
70b1464 to
62bb6f4
Compare
etagwerker
approved these changes
Jul 7, 2025
etagwerker
left a comment
etagwerker
left a comment
Member
There was a problem hiding this comment.
@arielj Looks good, thank you!
dduugg
reviewed
Jul 21, 2025
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_dependency "database_cleaner-core", "~>2.0.0" | ||
| spec.add_dependency "database_cleaner-core", "~>2.1.0" |
There was a problem hiding this comment.
There is no such version on rubygems: https://rubygems.org/gems/database_cleaner-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
database_cleaner-coreversion spec to match the one in the other repo (this was making the CI jobs fail during bundling)uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Loggererror when using the concurrent-ruby version 1.3.5 in older versions of rails uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError) on Rails 7.0.8.7 and concurrent-ruby 1.3.5 rails/rails#54271