Enforce include cleaner and regroup includes in cuttlefish/io

- Enable clang-tidy with 'with_include_cleaner' config for cuttlefish/io.
- Fix all include cleaner errors by adding direct includes and removing unused ones.
- Regroup all includes in cuttlefish/io to follow the 5-group style:
  1. Corresponding header
  2. C headers
  3. C++ headers
  4. Other projects (absl, gtest, etc.)
  5. Current project (cuttlefish/)
- Update BUILD.bazel dependencies for strict deps.

Assisted-by: Gemini:Next

Author: Databean

base/cvd/BUILD.bazel

@@ -27,6 +27,7 @@ filegroup(
     name = "clang_tidy_config",
     srcs = [
         ".clang-tidy",
+        "//cuttlefish/io:.clang-tidy",
         "//cuttlefish/common/libs/key_equals_value:.clang-tidy",
         "//cuttlefish/host/commands/assemble_cvd/android_build:.clang-tidy",
         "//cuttlefish/host/commands/cvd/cli/commands:.clang-tidy",

base/cvd/cuttlefish/io/.clang-tidy

@@ -0,0 +1 @@
+../../clang_tidy_configs/with_include_cleaner

base/cvd/cuttlefish/io/BUILD.bazel

@@ -6,6 +6,8 @@ package(
     default_visibility = ["//:android_cuttlefish"],
 )
 
+exports_files([".clang-tidy"])
+
 cf_cc_library(
     name = "chroot",
     srcs = ["chroot.cc"],
@@ -31,6 +33,7 @@ cf_cc_test(
         "//cuttlefish/io:filesystem",
         "//cuttlefish/io:in_memory",
         "//cuttlefish/io:string",
+        "//cuttlefish/result",
         "//cuttlefish/result:result_matchers",
     ],
 )
@@ -58,6 +61,7 @@ cf_cc_test(
         "//cuttlefish/io:concat",
         "//cuttlefish/io:in_memory",
         "//cuttlefish/io:string",
+        "//cuttlefish/result",
         "//cuttlefish/result:result_matchers",
     ],
 )
@@ -108,10 +112,12 @@ cf_cc_test(
     srcs = ["cpio_test.cc"],
     clang_format_enabled = True,
     deps = [
+        ":io",
         "//cuttlefish/io:cpio",
         "//cuttlefish/io:in_memory",
         "//cuttlefish/io:read_exact",
         "//cuttlefish/io:string",
+        "//cuttlefish/result",
         "//cuttlefish/result:result_matchers",
     ],
 )
@@ -222,6 +228,7 @@ cf_cc_test(
     srcs = ["in_memory_test.cc"],
     clang_format_enabled = True,
     deps = [
+        ":io",
         "//cuttlefish/io:in_memory",
         "//cuttlefish/result:result_matchers",
         "//cuttlefish/result:result_type",
@@ -300,12 +307,14 @@ cf_cc_test(
     srcs = ["lz4_legacy_test.cc"],
     clang_format_enabled = True,
     deps = [
+        ":io",
         "//cuttlefish/io:filesystem",
         "//cuttlefish/io:in_memory",
         "//cuttlefish/io:lz4_legacy",
         "//cuttlefish/io:read_exact",
         "//cuttlefish/io:string",
         "//cuttlefish/io:write_exact",
+        "//cuttlefish/result",
         "//cuttlefish/result:result_matchers",
     ],
 )
@@ -344,6 +353,7 @@ cf_cc_library(
     hdrs = ["read_window_view.h"],
     clang_format_enabled = True,
     deps = [
+        ":io",
         "//cuttlefish/io:fake_seek",
         "//cuttlefish/result:expect",
         "//cuttlefish/result:result_type",

base/cvd/cuttlefish/io/chroot.cc

@@ -18,6 +18,7 @@
 #include <stdint.h>
 
 #include <list>
+#include <memory>
 #include <string>
 #include <string_view>
 

base/cvd/cuttlefish/io/chroot.h

@@ -15,13 +15,12 @@
 
 #pragma once
 
-#include "cuttlefish/io/filesystem.h"
-
 #include <stdint.h>
 
 #include <string>
 #include <string_view>
 
+#include "cuttlefish/io/filesystem.h"
 #include "cuttlefish/io/io.h"
 #include "cuttlefish/result/result_type.h"
 

base/cvd/cuttlefish/io/chroot_test.cc

@@ -15,16 +15,18 @@
 
 #include "cuttlefish/io/chroot.h"
 
-#include <string>
+#include <memory>
 #include <string_view>
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 
 #include "cuttlefish/io/copy.h"
+#include "cuttlefish/io/filesystem.h"
 #include "cuttlefish/io/in_memory.h"
 #include "cuttlefish/io/io.h"
 #include "cuttlefish/io/string.h"
+#include "cuttlefish/result/result.h"
 #include "cuttlefish/result/result_matchers.h"
 
 namespace cuttlefish {

base/cvd/cuttlefish/io/concat.cc

@@ -15,8 +15,10 @@
 
 #include "cuttlefish/io/concat.h"
 
+#include <cstdint>
 #include <map>
 #include <memory>
+#include <utility>
 #include <vector>
 
 #include "cuttlefish/io/fake_seek.h"

base/cvd/cuttlefish/io/concat_test.cc

@@ -15,15 +15,18 @@
 
 #include "cuttlefish/io/concat.h"
 
-#include <string>
+#include <memory>
 #include <string_view>
+#include <utility>
+#include <vector>
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 
 #include "cuttlefish/io/in_memory.h"
 #include "cuttlefish/io/io.h"
 #include "cuttlefish/io/string.h"
+#include "cuttlefish/result/result.h"
 #include "cuttlefish/result/result_matchers.h"
 
 namespace cuttlefish {

base/cvd/cuttlefish/io/copy.cc

@@ -18,6 +18,7 @@
 #include <stddef.h>
 #include <stdint.h>
 
+#include <array>
 #include <memory>
 
 #include "cuttlefish/io/io.h"

base/cvd/cuttlefish/io/copy_test.cc

@@ -16,13 +16,13 @@
 #include "cuttlefish/io/copy.h"
 
 #include <memory>
-#include <string>
 #include <vector>
 
 #include "gmock/gmock-matchers.h"
 #include "gtest/gtest.h"
 
 #include "cuttlefish/io/in_memory.h"
+#include "cuttlefish/io/io.h"
 #include "cuttlefish/io/read_exact.h"
 #include "cuttlefish/result/result_matchers.h"