Skip to content

Commit 1c559c9

Browse files
jemoreiraDatabean
authored andcommitted
cvd: SummaryHelp returns string w/o Result wrapper
No implementation of that function should ever fail as command implementations should just return a constant string summarizing what the command does.
1 parent 48f70ca commit 1c559c9

26 files changed

Lines changed: 37 additions & 38 deletions

base/cvd/cuttlefish/host/commands/cvd/cli/commands/bugreport.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class CvdBugreportCommandHandler : public CvdCommandHandler {
9292

9393
Result<void> Handle(const CommandRequest& request) override;
9494
cvd_common::Args CmdList() const override;
95-
Result<std::string> SummaryHelp() const override;
95+
std::string SummaryHelp() const override;
9696

9797
bool RequiresDeviceExists() const override;
9898
Result<std::string> DetailedHelp(const CommandRequest& request) const override;
@@ -157,7 +157,7 @@ std::vector<std::string> CvdBugreportCommandHandler::CmdList() const {
157157
return {"bugreport", "host_bugreport", "cvd_host_bugreport"};
158158
}
159159

160-
Result<std::string> CvdBugreportCommandHandler::SummaryHelp() const {
160+
std::string CvdBugreportCommandHandler::SummaryHelp() const {
161161
return kSummaryHelpText;
162162
}
163163

base/cvd/cuttlefish/host/commands/cvd/cli/commands/cache.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class CvdCacheCommandHandler : public CvdCommandHandler {
9999
public:
100100
Result<void> Handle(const CommandRequest& request) override;
101101
cvd_common::Args CmdList() const override { return {"cache"}; }
102-
Result<std::string> SummaryHelp() const override;
102+
std::string SummaryHelp() const override;
103103

104104
Result<std::string> DetailedHelp(const CommandRequest& request) const override;
105105
};
@@ -149,7 +149,7 @@ Result<void> CvdCacheCommandHandler::Handle(const CommandRequest& request) {
149149
return {};
150150
}
151151

152-
Result<std::string> CvdCacheCommandHandler::SummaryHelp() const {
152+
std::string CvdCacheCommandHandler::SummaryHelp() const {
153153
return kSummaryHelpText;
154154
}
155155

base/cvd/cuttlefish/host/commands/cvd/cli/commands/clear.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class CvdClearCommandHandler : public CvdCommandHandler {
4040

4141
Result<void> Handle(const CommandRequest& request) override;
4242
cvd_common::Args CmdList() const override { return {kClearCmd}; }
43-
Result<std::string> SummaryHelp() const override { return kSummaryHelpText; }
43+
std::string SummaryHelp() const override { return kSummaryHelpText; }
4444

4545
bool RequiresDeviceExists() const override { return true; }
4646
Result<std::string> DetailedHelp(const CommandRequest& request) const override;

base/cvd/cuttlefish/host/commands/cvd/cli/commands/command_handler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class CvdCommandHandler {
3333
// returns the list of subcommand it can handle
3434
virtual cvd_common::Args CmdList() const = 0;
3535
// used for command help text
36-
virtual Result<std::string> SummaryHelp() const = 0;
36+
virtual std::string SummaryHelp() const = 0;
3737
virtual bool RequiresDeviceExists() const;
3838
virtual Result<std::string> DetailedHelp(const CommandRequest&) const = 0;
3939
};

base/cvd/cuttlefish/host/commands/cvd/cli/commands/create.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class CvdCreateCommandHandler : public CvdCommandHandler {
209209

210210
Result<void> Handle(const CommandRequest& request) override;
211211
std::vector<std::string> CmdList() const override { return {"create"}; }
212-
Result<std::string> SummaryHelp() const override;
212+
std::string SummaryHelp() const override;
213213

214214
Result<std::string> DetailedHelp(const CommandRequest& request) const override;
215215

@@ -345,7 +345,7 @@ Result<void> CvdCreateCommandHandler::Handle(const CommandRequest& request) {
345345
return {};
346346
}
347347

348-
Result<std::string> CvdCreateCommandHandler::SummaryHelp() const {
348+
std::string CvdCreateCommandHandler::SummaryHelp() const {
349349
return kSummaryHelpText;
350350
}
351351

base/cvd/cuttlefish/host/commands/cvd/cli/commands/display.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class CvdDisplayCommandHandler : public CvdCommandHandler {
8787

8888
cvd_common::Args CmdList() const override { return {"display"}; }
8989

90-
Result<std::string> SummaryHelp() const override { return kSummaryHelpText; }
90+
std::string SummaryHelp() const override { return kSummaryHelpText; }
9191

9292

9393

base/cvd/cuttlefish/host/commands/cvd/cli/commands/env.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class CvdEnvCommandHandler : public CvdCommandHandler {
7676

7777
cvd_common::Args CmdList() const override { return {"env"}; }
7878

79-
Result<std::string> SummaryHelp() const override { return kSummaryHelpText; }
79+
std::string SummaryHelp() const override { return kSummaryHelpText; }
8080

8181

8282

base/cvd/cuttlefish/host/commands/cvd/cli/commands/fetch.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class CvdFetchCommandHandler : public CvdCommandHandler {
4747
public:
4848
Result<void> Handle(const CommandRequest& request) override;
4949
cvd_common::Args CmdList() const override { return {"fetch", "fetch_cvd"}; }
50-
Result<std::string> SummaryHelp() const override;
50+
std::string SummaryHelp() const override;
5151

5252
Result<std::string> DetailedHelp(const CommandRequest& request) const override;
5353
};
@@ -119,7 +119,7 @@ Result<void> CvdFetchCommandHandler::Handle(const CommandRequest& request) {
119119
return {};
120120
}
121121

122-
Result<std::string> CvdFetchCommandHandler::SummaryHelp() const {
122+
std::string CvdFetchCommandHandler::SummaryHelp() const {
123123
return "Retrieve build artifacts based on branch and target names";
124124
}
125125

base/cvd/cuttlefish/host/commands/cvd/cli/commands/fleet.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class CvdFleetCommandHandler : public CvdCommandHandler {
4949
Result<void> Handle(const CommandRequest& request) override;
5050
cvd_common::Args CmdList() const override { return {kFleetSubcmd}; }
5151

52-
Result<std::string> SummaryHelp() const override { return kSummaryHelpText; }
52+
std::string SummaryHelp() const override { return kSummaryHelpText; }
5353

5454

5555

base/cvd/cuttlefish/host/commands/cvd/cli/commands/help.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class CvdHelpHandler : public CvdCommandHandler {
8383

8484
std::vector<std::string> args = request.SubcommandArguments();
8585
if (args.empty()) {
86-
std::cout << CF_EXPECT(TopLevelHelp());
86+
std::cout << TopLevelHelp();
8787
} else {
8888
std::cout << CF_EXPECT(SubCommandHelp(request));
8989
}
@@ -93,7 +93,7 @@ class CvdHelpHandler : public CvdCommandHandler {
9393

9494
cvd_common::Args CmdList() const override { return {"help"}; }
9595

96-
Result<std::string> SummaryHelp() const override { return kSummaryHelpText; }
96+
std::string SummaryHelp() const override { return kSummaryHelpText; }
9797

9898

9999

@@ -107,13 +107,13 @@ class CvdHelpHandler : public CvdCommandHandler {
107107
return CF_EXPECT(std::move(builder).Build());
108108
}
109109

110-
Result<std::string> TopLevelHelp() {
110+
std::string TopLevelHelp() {
111111
std::stringstream help_message;
112112
help_message << kHelpIntroText;
113113

114114
for (const auto& handler : request_handlers_) {
115115
if (!handler->RequiresDeviceExists()) {
116-
CF_EXPECT(PrintHandler(help_message, *handler));
116+
PrintHandler(help_message, *handler);
117117
}
118118
}
119119

@@ -122,18 +122,17 @@ class CvdHelpHandler : public CvdCommandHandler {
122122
"information):\n";
123123
for (const auto& handler : request_handlers_) {
124124
if (handler->RequiresDeviceExists()) {
125-
CF_EXPECT(PrintHandler(help_message, *handler));
125+
PrintHandler(help_message, *handler);
126126
}
127127
}
128128

129129
return help_message.str();
130130
}
131131

132-
Result<void> PrintHandler(std::stringstream& help_message,
132+
void PrintHandler(std::stringstream& help_message,
133133
const CvdCommandHandler& handler) const {
134134
help_message << "\t" << absl::StrJoin(handler.CmdList(), ", ") << " - ";
135-
help_message << CF_EXPECT(handler.SummaryHelp()) << "\n\n";
136-
return {};
135+
help_message << handler.SummaryHelp() << "\n\n";
137136
}
138137

139138
Result<std::string> SubCommandHelp(const CommandRequest& request) {

0 commit comments

Comments
 (0)