Skip to content

Commit 1f20e1c

Browse files
committed
Move switches_socket_path to config_instance_derived.cc
Bug: b/474188702 #gemini
1 parent 22094f8 commit 1f20e1c

7 files changed

Lines changed: 9 additions & 8 deletions

File tree

base/cvd/cuttlefish/host/commands/run_cvd/launch/vhost_input_devices.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ class VhostInputDevices : public CommandSource,
296296
CF_EXPECT(NewDeviceSockets(KeyboardSocketPath(instance_)),
297297
"Failed to setup sockets for keyboard device");
298298
switches_sockets_ =
299-
CF_EXPECT(NewDeviceSockets(instance_.switches_socket_path()),
299+
CF_EXPECT(NewDeviceSockets(SwitchesSocketPath(instance_)),
300300
"Failed to setup sockets for switches device");
301301
touchscreen_sockets_.reserve(instance_.display_configs().size());
302302
for (int i = 0; i < instance_.display_configs().size(); ++i) {

base/cvd/cuttlefish/host/libs/config/config_instance_derived.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ std::string RotarySocketPath(const CuttlefishConfig::InstanceSpecific& ins) {
8787
return ins.PerInstanceInternalUdsPath("rotary.sock");
8888
}
8989

90+
std::string SwitchesSocketPath(const CuttlefishConfig::InstanceSpecific& ins) {
91+
return ins.PerInstanceInternalUdsPath("switches.sock");
92+
}
93+
9094
std::string RestoreAdbdPipeName(const CuttlefishConfig::InstanceSpecific& ins) {
9195
return AbsolutePath(ins.PerInstanceInternalPath("restore-pipe-adbd"));
9296
}

base/cvd/cuttlefish/host/libs/config/config_instance_derived.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ std::string MouseSocketPath(const CuttlefishConfig::InstanceSpecific&);
3838
std::string PflashPath(const CuttlefishConfig::InstanceSpecific&);
3939
std::string PstorePath(const CuttlefishConfig::InstanceSpecific&);
4040
std::string RotarySocketPath(const CuttlefishConfig::InstanceSpecific&);
41+
std::string SwitchesSocketPath(const CuttlefishConfig::InstanceSpecific&);
4142
std::string RestoreAdbdPipeName(const CuttlefishConfig::InstanceSpecific&);
4243

4344
} // namespace cuttlefish

base/cvd/cuttlefish/host/libs/config/cuttlefish_config.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ class CuttlefishConfig {
352352
std::string instance_internal_uds_dir() const;
353353

354354
std::string touch_socket_path(int touch_dev_idx) const;
355-
std::string switches_socket_path() const;
356355

357356
std::string launcher_log_path() const;
358357

base/cvd/cuttlefish/host/libs/config/cuttlefish_config_instance.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1848,10 +1848,6 @@ std::string CuttlefishConfig::InstanceSpecific::touch_socket_path(
18481848
return PerInstanceInternalUdsPath(name);
18491849
}
18501850

1851-
std::string CuttlefishConfig::InstanceSpecific::switches_socket_path() const {
1852-
return PerInstanceInternalUdsPath("switches.sock");
1853-
}
1854-
18551851
static constexpr char kFrameSockPath[] = "frame_sock_path";
18561852
void CuttlefishConfig::MutableInstanceSpecific::set_frames_socket_path(
18571853
const std::string& frame_socket_path) {

base/cvd/cuttlefish/host/libs/vm_manager/crosvm_manager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ Result<std::vector<MonitorCommand>> CrosvmManager::StartCommands(
655655
}
656656
crosvm_cmd.AddVhostUser("input", RotarySocketPath(instance));
657657
crosvm_cmd.AddVhostUser("input", KeyboardSocketPath(instance));
658-
crosvm_cmd.AddVhostUser("input", instance.switches_socket_path());
658+
crosvm_cmd.AddVhostUser("input", SwitchesSocketPath(instance));
659659
}
660660

661661
#ifdef __linux__

base/cvd/cuttlefish/host/libs/vm_manager/qemu_manager.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,8 @@ Result<std::vector<MonitorCommand>> QemuManager::StartCommands(
762762

763763
// device padding for unsupported "switches" input
764764
qemu_cmd.AddParameter("-chardev");
765-
qemu_cmd.AddParameter("socket,path=", instance.switches_socket_path(), ",id=switches0");
765+
qemu_cmd.AddParameter("socket,path=", SwitchesSocketPath(instance),
766+
",id=switches0");
766767
qemu_cmd.AddParameter("-device");
767768
qemu_cmd.AddParameter("vhost-user-input-pci,chardev=switches0");
768769

0 commit comments

Comments
 (0)