Skip to content

Commit 929626d

Browse files
committed
Move keyboard_socket_path to config_instance_derived.cc
Bug: b/474188702 #gemini
1 parent ddf18da commit 929626d

6 files changed

Lines changed: 7 additions & 7 deletions

File tree

base/cvd/cuttlefish/host/commands/run_cvd/launch/vhost_input_devices.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ class VhostInputDevices : public CommandSource,
293293
"Failed to setup sockets for gamepad device");
294294
}
295295
keyboard_sockets_ =
296-
CF_EXPECT(NewDeviceSockets(instance_.keyboard_socket_path()),
296+
CF_EXPECT(NewDeviceSockets(KeyboardSocketPath(instance_)),
297297
"Failed to setup sockets for keyboard device");
298298
switches_sockets_ =
299299
CF_EXPECT(NewDeviceSockets(instance_.switches_socket_path()),

base/cvd/cuttlefish/host/libs/config/config_instance_derived.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ std::string KernelLogPipeName(const CuttlefishConfig::InstanceSpecific& ins) {
5454
return AbsolutePath(ins.PerInstanceInternalPath("kernel-log-pipe"));
5555
}
5656

57+
std::string KeyboardSocketPath(const CuttlefishConfig::InstanceSpecific& ins) {
58+
return ins.PerInstanceInternalUdsPath("keyboard.sock");
59+
}
60+
5761
std::string LauncherMonitorSocketPath(
5862
const CuttlefishConfig::InstanceSpecific& ins) {
5963
return AbsolutePath(ins.PerInstanceUdsPath("launcher_monitor.sock"));

base/cvd/cuttlefish/host/libs/config/config_instance_derived.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ std::string ConsolePipePrefix(const CuttlefishConfig::InstanceSpecific&);
2929
std::string GamepadSocketPath(const CuttlefishConfig::InstanceSpecific&);
3030
std::string HwcomposerPmemPath(const CuttlefishConfig::InstanceSpecific&);
3131
std::string KernelLogPipeName(const CuttlefishConfig::InstanceSpecific& ins);
32+
std::string KeyboardSocketPath(const CuttlefishConfig::InstanceSpecific&);
3233
std::string LauncherMonitorSocketPath(
3334
const CuttlefishConfig::InstanceSpecific&);
3435
std::string LogcatPath(const CuttlefishConfig::InstanceSpecific&);

base/cvd/cuttlefish/host/libs/config/cuttlefish_config.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ class CuttlefishConfig {
352352
std::string instance_internal_uds_dir() const;
353353

354354
std::string touch_socket_path(int touch_dev_idx) const;
355-
std::string keyboard_socket_path() const;
356355
std::string switches_socket_path() const;
357356

358357
std::string launcher_log_path() const;

base/cvd/cuttlefish/host/libs/config/cuttlefish_config_instance.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1848,10 +1848,6 @@ std::string CuttlefishConfig::InstanceSpecific::touch_socket_path(
18481848
return PerInstanceInternalUdsPath(name);
18491849
}
18501850

1851-
std::string CuttlefishConfig::InstanceSpecific::keyboard_socket_path() const {
1852-
return PerInstanceInternalUdsPath("keyboard.sock");
1853-
}
1854-
18551851
std::string CuttlefishConfig::InstanceSpecific::switches_socket_path() const {
18561852
return PerInstanceInternalUdsPath("switches.sock");
18571853
}

base/cvd/cuttlefish/host/libs/vm_manager/crosvm_manager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ Result<std::vector<MonitorCommand>> CrosvmManager::StartCommands(
654654
crosvm_cmd.AddVhostUser("input", GamepadSocketPath(instance));
655655
}
656656
crosvm_cmd.AddVhostUser("input", RotarySocketPath(instance));
657-
crosvm_cmd.AddVhostUser("input", instance.keyboard_socket_path());
657+
crosvm_cmd.AddVhostUser("input", KeyboardSocketPath(instance));
658658
crosvm_cmd.AddVhostUser("input", instance.switches_socket_path());
659659
}
660660

0 commit comments

Comments
 (0)