Skip to content

Commit a45d8c8

Browse files
committed
1 parent cf0d080 commit a45d8c8

5 files changed

Lines changed: 13 additions & 42 deletions

File tree

base/cvd/cuttlefish/host/commands/assemble_cvd/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ cf_cc_library(
174174
"//cuttlefish/host/libs/feature:inject",
175175
"//cuttlefish/host/libs/vm_manager",
176176
"//libbase",
177-
"@fruit",
178177
"@gflags",
179178
],
180179
)

base/cvd/cuttlefish/host/commands/assemble_cvd/disk/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,7 @@ cf_cc_library(
126126
"//cuttlefish/common/libs/utils:files",
127127
"//cuttlefish/common/libs/utils:result",
128128
"//cuttlefish/host/commands/assemble_cvd:boot_image_utils",
129-
"//cuttlefish/host/commands/assemble_cvd/disk:kernel_ramdisk_repacker",
130129
"//cuttlefish/host/libs/config:cuttlefish_config",
131-
"//cuttlefish/host/libs/feature",
132130
"//libbase",
133131
],
134132
)

base/cvd/cuttlefish/host/commands/assemble_cvd/disk/gem5_image_unpacker.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,11 @@
2121
#include "cuttlefish/common/libs/utils/files.h"
2222
#include "cuttlefish/common/libs/utils/result.h"
2323
#include "cuttlefish/host/commands/assemble_cvd/boot_image_utils.h"
24-
#include "cuttlefish/host/commands/assemble_cvd/disk/kernel_ramdisk_repacker.h"
2524
#include "cuttlefish/host/libs/config/cuttlefish_config.h"
26-
#include "cuttlefish/host/libs/feature/feature.h"
2725

2826
namespace cuttlefish {
2927

30-
Result<void> Gem5ImageUnpacker(
31-
const CuttlefishConfig& config,
32-
AutoSetup<RepackKernelRamdisk>::Type& /* dependency */) {
28+
Result<void> Gem5ImageUnpacker(const CuttlefishConfig& config) {
3329
if (config.vm_manager() != VmmMode::kGem5) {
3430
return {};
3531
}

base/cvd/cuttlefish/host/commands/assemble_cvd/disk/gem5_image_unpacker.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@
1616

1717
#pragma once
1818

19-
#include "cuttlefish/host/commands/assemble_cvd/disk/kernel_ramdisk_repacker.h"
2019
#include "cuttlefish/host/libs/config/cuttlefish_config.h"
21-
#include "cuttlefish/host/libs/feature/feature.h"
2220

2321
namespace cuttlefish {
2422

25-
Result<void> Gem5ImageUnpacker(const CuttlefishConfig&,
26-
AutoSetup<RepackKernelRamdisk>::Type&);
23+
// Requires KernelRamdiskRepacker
24+
Result<void> Gem5ImageUnpacker(const CuttlefishConfig&);
2725

2826
} // namespace cuttlefish

base/cvd/cuttlefish/host/commands/assemble_cvd/disk_flags.cc

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include <android-base/parsebool.h>
2626
#include <android-base/parseint.h>
2727
#include <android-base/strings.h>
28-
#include <fruit/fruit.h>
2928
#include <gflags/gflags.h>
3029

3130
#include "cuttlefish/common/libs/utils/files.h"
@@ -63,7 +62,6 @@
6362
#include "cuttlefish/host/libs/config/data_image.h"
6463
#include "cuttlefish/host/libs/config/fetcher_config.h"
6564
#include "cuttlefish/host/libs/config/instance_nums.h"
66-
#include "cuttlefish/host/libs/feature/inject.h"
6765
#include "cuttlefish/host/libs/vm_manager/gem5_manager.h"
6866

6967
namespace cuttlefish {
@@ -207,24 +205,6 @@ static uint64_t AvailableSpaceAtPath(const std::string& path) {
207205
return static_cast<uint64_t>(vfs.f_frsize) * vfs.f_bavail;
208206
}
209207

210-
static fruit::Component<> DiskChangesComponent(
211-
const FetcherConfig* fetcher, const CuttlefishConfig* config,
212-
const CuttlefishConfig::InstanceSpecific* instance) {
213-
return fruit::createComponent()
214-
.bindInstance(*fetcher)
215-
.bindInstance(*config)
216-
.bindInstance(*instance)
217-
.install(CuttlefishKeyAvbComponent)
218-
.install(AutoSetup<InitializeChromeOsState>::Component)
219-
.install(AutoSetup<RepackKernelRamdisk>::Component)
220-
.install(AutoSetup<VbmetaEnforceMinimumSize>::Component)
221-
.install(AutoSetup<BootloaderPresentCheck>::Component)
222-
.install(AutoSetup<Gem5ImageUnpacker>::Component)
223-
// Create esp if necessary
224-
.install(AutoSetup<InitializeEspImage>::Component)
225-
.install(AutoSetup<RebuildSuperImageIfNecessary>::Component);
226-
}
227-
228208
Result<void> DiskImageFlagsVectorization(
229209
CuttlefishConfig& config, const FetcherConfig& fetcher_config,
230210
const InitramfsPathFlag& initramfs_path, const KernelPathFlag& kernel_path,
@@ -492,16 +472,16 @@ Result<void> CreateDynamicDiskFiles(
492472
const FetcherConfig& fetcher_config, const CuttlefishConfig& config,
493473
const SystemImageDirFlag& system_image_dir) {
494474
for (const auto& instance : config.Instances()) {
495-
// TODO(schuffelen): Unify this with the other injector created in
496-
// assemble_cvd.cpp
497-
fruit::Injector<> injector(DiskChangesComponent, &fetcher_config, &config,
498-
&instance);
499-
for (auto& late_injected : injector.getMultibindings<LateInjected>()) {
500-
CF_EXPECT(late_injected->LateInject(injector));
501-
}
502-
503-
const auto& features = injector.getMultibindings<SetupFeature>();
504-
CF_EXPECT(SetupFeature::RunSetup(features));
475+
std::unique_ptr<Avb> avb = GetDefaultAvb();
476+
CF_EXPECT(avb.get());
477+
478+
CF_EXPECT(InitializeChromeOsState(instance));
479+
CF_EXPECT(RepackKernelRamdisk(config, instance, *avb));
480+
CF_EXPECT(VbmetaEnforceMinimumSize(instance));
481+
CF_EXPECT(BootloaderPresentCheck(instance));
482+
CF_EXPECT(Gem5ImageUnpacker(config)); // Requires RepackKernelRamdisk
483+
CF_EXPECT(InitializeEspImage(config, instance));
484+
CF_EXPECT(RebuildSuperImageIfNecessary(fetcher_config, instance));
505485

506486
CF_EXPECT(InitializeAccessKregistryImage(instance));
507487
CF_EXPECT(InitializeHwcomposerPmemImage(instance));

0 commit comments

Comments
 (0)