Skip to content

Commit bf92531

Browse files
committed
cvd start now works after cvd detects is in container environment.
- `enable_sandbox` is calculated dynamically on second `cvd start`, true if running directly in the host, false if running in a container. As `cvd` wasn't detecting podman container environments yet, it assumed it was running directly in the host defaulting to enable_sandbox to true which fails if running in a container. Bug: b/523379344
1 parent 9426ceb commit bf92531

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

e2etests/orchestration/stop_start_test/main_test.go

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,16 @@ func TestStopStart(t *testing.T) {
104104
t.Fatalf("status mismatch (-want +got):\n%s", diff)
105105
}
106106

107-
// TODO(b/523379344): Failing to boot.
108-
// if err := srv.StartGroup("cvd_1", &hoapi.StartCVDRequest{}); err != nil {
109-
// t.Fatal(err)
110-
// }
111-
// cvds, err = srv.ListCVDs()
112-
// if err != nil {
113-
// t.Fatal(err)
114-
// }
115-
// if diff := cmp.Diff(cvdStatus(cvds), []string{"Running", "Running"}); diff != "" {
116-
// t.Fatalf("status mismatch (-want +got):\n%s", diff)
117-
// }
107+
if err := srv.StartGroup("cvd_1", &hoapi.StartCVDRequest{}); err != nil {
108+
t.Fatal(err)
109+
}
110+
cvds, err = srv.ListCVDs()
111+
if err != nil {
112+
t.Fatal(err)
113+
}
114+
if diff := cmp.Diff(cvdStatus(cvds), []string{"Running", "Running"}); diff != "" {
115+
t.Fatalf("status mismatch (-want +got):\n%s", diff)
116+
}
118117
}
119118

120119
func cvdStatus(cvds []*hoapi.CVD) []string {

0 commit comments

Comments
 (0)