Skip to content

Commit c84abda

Browse files
committed
Migrate external third-party library includes to double quotes on tested files
Convert #include <lib/...> to #include "lib/..." for third-party libraries (e.g. gflags, gtest, android-base) across all source files verified by format_test_srcs targets, while preserving plain C library headers like <zip.h> as angle brackets and keeping all IWYU pragma comments intact. Assisted-by: Jetski:Gemini Next
1 parent 6f97ce4 commit c84abda

175 files changed

Lines changed: 282 additions & 282 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.clang-format

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ IncludeCategories:
2525
Priority: 4
2626
- Regex: '^<(zip|zlib|png|lz4|archive|tinyxml2|pcre2)\.h>'
2727
Priority: 3
28-
- Regex: '^<([^/]*|(sys|linux|netinet|arpa|asm|net|gnu)/.*)\.h>'
28+
- Regex: '^<.*\.h>'
2929
Priority: 1
3030
- Regex: '^<[a-z_]*>'
3131
Priority: 2

base/cvd/cuttlefish/common/libs/fs/shared_fd_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
#include <unistd.h>
2020

21-
#include <gtest/gtest.h>
21+
#include "gtest/gtest.h"
2222

2323
namespace cuttlefish {
2424

base/cvd/cuttlefish/common/libs/utils/base64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include <string_view>
2424
#include <vector>
2525

26-
#include <openssl/base64.h>
26+
#include "openssl/base64.h"
2727

2828
#include "cuttlefish/result/expect.h"
2929
#include "cuttlefish/result/result_type.h"

base/cvd/cuttlefish/common/libs/utils/cf_endian.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
#include <inttypes.h>
1919

20-
#include <android-base/endian.h>
20+
#include "android-base/endian.h"
2121

2222
// The utilities in android-base/endian.h still require the use of regular int
2323
// types to store values with any endianness, which requires the user to

base/cvd/cuttlefish/common/libs/utils/environment_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include <string_view>
2222

2323
#include "absl/cleanup/cleanup.h"
24-
#include <gtest/gtest.h>
24+
#include "gtest/gtest.h"
2525

2626
namespace cuttlefish {
2727

base/cvd/cuttlefish/common/libs/utils/files_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020

2121
#include "absl/cleanup/cleanup.h"
2222
#include "absl/strings/str_cat.h"
23-
#include <android-base/file.h>
24-
#include <gmock/gmock.h>
25-
#include <gtest/gtest.h>
23+
#include "android-base/file.h"
24+
#include "gmock/gmock.h"
25+
#include "gtest/gtest.h"
2626

2727
#include "cuttlefish/result/result.h"
2828
#include "cuttlefish/result/result_matchers.h"

base/cvd/cuttlefish/common/libs/utils/gflags_xml_parser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <string_view>
2121
#include <vector>
2222

23-
#include <libxml/parser.h>
23+
#include "libxml/parser.h"
2424

2525
#include "cuttlefish/result/result.h"
2626

base/cvd/cuttlefish/common/libs/utils/gflags_xml_parser_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
#include <string>
1919
#include <vector>
2020

21-
#include <gmock/gmock.h>
22-
#include <gtest/gtest.h>
21+
#include "gmock/gmock.h"
22+
#include "gtest/gtest.h"
2323

2424
#include "cuttlefish/result/result_matchers.h"
2525

base/cvd/cuttlefish/common/libs/utils/json.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include <string_view>
2020
#include <vector>
2121

22-
#include <json/json.h>
22+
#include "json/json.h"
2323

2424
#include "cuttlefish/common/libs/fs/shared_fd.h"
2525
#include "cuttlefish/result/result.h"

base/cvd/cuttlefish/common/libs/utils/network_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
#include "cuttlefish/common/libs/utils/network.h"
1717

18-
#include <gtest/gtest.h>
18+
#include "gtest/gtest.h"
1919

2020
namespace cuttlefish {
2121
namespace {

0 commit comments

Comments
 (0)