Enable clang-format for formatted targets in cuttlefish

Enable clang_format_enabled = True for all cf_cc_* targets under
base/cvd/cuttlefish that only contain files that are already formatted
correctly.

Also fix a duplicate header in cvdalloc/BUILD.bazel.

Bug: b/512215781
Assisted-by: gemini-next:current

Author: Databean

base/cvd/cuttlefish/common/libs/concurrency/BUILD.bazel

@@ -11,5 +11,6 @@ cf_cc_library(
         "semaphore.h",
         "thread_safe_queue.h",
     ],
+    clang_format_enabled = True,
     deps = ["@abseil-cpp//absl/log:check"],
 )

base/cvd/cuttlefish/common/libs/fs/BUILD.bazel

@@ -8,6 +8,7 @@ cf_cc_library(
     name = "epoll",
     srcs = ["epoll.cpp"],
     hdrs = ["epoll.h"],
+    clang_format_enabled = True,
     target_compatible_with = [
         "@platforms//os:linux",
     ],

base/cvd/cuttlefish/common/libs/security/BUILD.bazel

@@ -12,6 +12,7 @@ cf_cc_library(
     hdrs = [
         "confui_sign.h",
     ],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//libbase",
@@ -22,4 +23,5 @@ cf_cc_library(
 cf_cc_library(
     name = "oemlock",
     hdrs = ["oemlock.h"],
+    clang_format_enabled = True,
 )

base/cvd/cuttlefish/common/libs/sensors/BUILD.bazel

@@ -9,4 +9,5 @@ cf_cc_library(
     hdrs = [
         "sensors.h",
     ],
+    clang_format_enabled = True,
 )

base/cvd/cuttlefish/common/libs/utils/BUILD.bazel

@@ -22,6 +22,7 @@ cf_cc_library(
     name = "base64",
     srcs = ["base64.cpp"],
     hdrs = ["base64.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/result:expect",
         "//cuttlefish/result:result_type",
@@ -42,6 +43,7 @@ cf_cc_test(
 cf_cc_library(
     name = "cf_endian",
     hdrs = ["cf_endian.h"],
+    clang_format_enabled = True,
     deps = [
         "//libbase",
     ],
@@ -51,18 +53,21 @@ cf_cc_library(
     name = "container",
     srcs = ["container.cpp"],
     hdrs = ["container.h"],
+    clang_format_enabled = True,
     deps = ["//cuttlefish/common/libs/utils:files"],
 )
 
 cf_cc_library(
     name = "contains",
     hdrs = ["contains.h"],
+    clang_format_enabled = True,
 )
 
 cf_cc_library(
     name = "device_type",
     srcs = ["device_type.cpp"],
     hdrs = ["device_type.h"],
+    clang_format_enabled = True,
     deps = [
         "@abseil-cpp//absl/strings",
     ],
@@ -91,6 +96,7 @@ cf_cc_library(
         "environment.h",
         "known_paths.h",
     ],
+    clang_format_enabled = True,
     deps = [
         "//libbase",
     ],
@@ -99,6 +105,7 @@ cf_cc_library(
 cf_cc_test(
     name = "environment_test",
     srcs = ["environment_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         ":environment",
         "@abseil-cpp//absl/cleanup",
@@ -133,6 +140,7 @@ cf_cc_library(
 cf_cc_test(
     name = "files_test",
     srcs = ["files_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:files",
         "//cuttlefish/result",
@@ -147,6 +155,7 @@ cf_cc_library(
     name = "flags_validator",
     srcs = ["flags_validator.cpp"],
     hdrs = ["flags_validator.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/result",
     ],
@@ -156,6 +165,7 @@ cf_cc_library(
     name = "gflags_xml_parser",
     srcs = ["gflags_xml_parser.cpp"],
     hdrs = ["gflags_xml_parser.h"],
+    clang_format_enabled = True,
     features = ["-layering_check"],
     deps = [
         "//cuttlefish/result",
@@ -166,6 +176,7 @@ cf_cc_library(
 cf_cc_test(
     name = "gflags_xml_parser_test",
     srcs = ["gflags_xml_parser_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         ":gflags_xml_parser",
         "//cuttlefish/result:result_matchers",
@@ -188,12 +199,14 @@ cf_cc_library(
     name = "in_sandbox",
     srcs = ["in_sandbox.cpp"],
     hdrs = ["in_sandbox.h"],
+    clang_format_enabled = True,
 )
 
 cf_cc_library(
     name = "inotify",
     srcs = ["inotify.cpp"],
     hdrs = ["inotify.h"],
+    clang_format_enabled = True,
     target_compatible_with = [
         "@platforms//os:linux",
     ],
@@ -207,6 +220,7 @@ cf_cc_library(
     name = "is_google_corp",
     srcs = ["is_google_corp.cpp"],
     hdrs = ["is_google_corp.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:files",
     ],
@@ -216,6 +230,7 @@ cf_cc_library(
     name = "json",
     srcs = ["json.cpp"],
     hdrs = ["json.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//cuttlefish/result",
@@ -242,13 +257,15 @@ cf_cc_library(
 cf_cc_test(
     name = "network_test",
     srcs = ["network_test.cpp"],
+    clang_format_enabled = True,
     deps = [":network"],
 )
 
 cf_cc_library(
     name = "proc_file_utils",
     srcs = ["proc_file_utils.cpp"],
     hdrs = ["proc_file_utils.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//cuttlefish/common/libs/utils:files",
@@ -263,6 +280,7 @@ cf_cc_library(
 cf_cc_test(
     name = "proc_file_utils_test",
     srcs = ["proc_file_utils_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:contains",
         "//cuttlefish/common/libs/utils:proc_file_utils",
@@ -273,6 +291,7 @@ cf_cc_test(
 cf_cc_library(
     name = "proto",
     hdrs = ["proto.h"],
+    clang_format_enabled = True,
     deps = [
         "@fmt",
         "@protobuf",
@@ -294,6 +313,7 @@ cf_cc_library(
     name = "semver",
     srcs = ["semver.cpp"],
     hdrs = ["semver.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/result",
         "//cuttlefish/result:expect",
@@ -304,6 +324,7 @@ cf_cc_library(
 cf_cc_test(
     name = "semver_test",
     srcs = ["semver_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:semver",
         "//cuttlefish/result:result_matchers",
@@ -324,6 +345,7 @@ cf_cc_library(
 cf_cc_library(
     name = "size_utils",
     hdrs = ["size_utils.h"],
+    clang_format_enabled = True,
 )
 
 cf_cc_library(
@@ -344,6 +366,7 @@ cf_cc_library(
     name = "subprocess",
     srcs = ["subprocess.cpp"],
     hdrs = ["subprocess.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//cuttlefish/common/libs/utils:contains",
@@ -394,6 +417,7 @@ cf_cc_library(
 cf_cc_library(
     name = "type_name",
     hdrs = ["type_name.h"],
+    clang_format_enabled = True,
 )
 
 cf_cc_library(
@@ -404,6 +428,7 @@ cf_cc_library(
     hdrs = [
         "uuid.h",
     ],
+    clang_format_enabled = True,
     deps = [
         "@libuuid",
     ],
@@ -413,6 +438,7 @@ cf_cc_library(
     name = "unix_sockets",
     srcs = ["unix_sockets.cpp"],
     hdrs = ["unix_sockets.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//cuttlefish/result",
@@ -425,6 +451,7 @@ cf_cc_library(
 cf_cc_test(
     name = "unix_sockets_test",
     srcs = ["unix_sockets_test.cpp"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/fs",
         "//cuttlefish/common/libs/utils:unix_sockets",
@@ -466,6 +493,7 @@ cf_cc_library(
     name = "wait_for_file",
     srcs = ["wait_for_file.cc"],
     hdrs = ["wait_for_file.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:contains",
         "//cuttlefish/common/libs/utils:files",

base/cvd/cuttlefish/flag_parser/BUILD.bazel

@@ -38,6 +38,7 @@ cf_cc_library(
     name = "shared_fd_flag",
     srcs = ["shared_fd_flag.cpp"],
     hdrs = ["shared_fd_flag.h"],
+    clang_format_enabled = True,
     deps = [
         ":flag_parser",
         "//cuttlefish/common/libs/fs",

base/cvd/cuttlefish/host/commands/assemble_cvd/BUILD.bazel

@@ -182,6 +182,7 @@ cf_cc_library(
     name = "create_dynamic_disk_files",
     srcs = ["create_dynamic_disk_files.cc"],
     hdrs = ["create_dynamic_disk_files.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:files",
         "//cuttlefish/host/commands/assemble_cvd:assemble_cvd_flags",
@@ -235,6 +236,7 @@ cf_cc_library(
     name = "disk_builder",
     srcs = ["disk_builder.cpp"],
     hdrs = ["disk_builder.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/common/libs/utils:files",
         "//cuttlefish/host/libs/config:vmm_mode",
@@ -375,6 +377,7 @@ cf_cc_library(
     hdrs = [
         "flags_defaults.h",
     ],
+    clang_format_enabled = True,
     copts = COPTS + ["-Werror=sign-compare"],
     deps = [
         "//cuttlefish/common/libs/utils:environment",
@@ -449,6 +452,7 @@ cf_cc_library(
     name = "kernel_module_parser",
     srcs = ["kernel_module_parser.cc"],
     hdrs = ["kernel_module_parser.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/io",
         "//cuttlefish/io:string",
@@ -460,6 +464,7 @@ cf_cc_library(
 cf_cc_test(
     name = "kernel_module_parser_test",
     srcs = ["kernel_module_parser_test.cc"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/host/commands/assemble_cvd:kernel_module_parser",
         "//cuttlefish/io",
@@ -492,6 +497,7 @@ cf_cc_library(
     name = "instance_image_files",
     srcs = ["instance_image_files.cc"],
     hdrs = ["instance_image_files.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/host/commands/assemble_cvd/disk:efi_loader",
         "//cuttlefish/host/commands/assemble_cvd/disk:image_file",
@@ -523,6 +529,7 @@ cf_cc_library(
     name = "network_flags",
     srcs = ["network_flags.cpp"],
     hdrs = ["network_flags.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/host/commands/cvdalloc:interface",
         "//cuttlefish/host/libs/config:cuttlefish_config",
@@ -538,6 +545,7 @@ cf_cc_library(
     name = "required_directories",
     srcs = ["required_directories.cc"],
     hdrs = ["required_directories.h"],
+    clang_format_enabled = True,
     deps = [
         "//cuttlefish/host/libs/config:config_constants",
         "//cuttlefish/host/libs/config:cuttlefish_config",