Enable include-cleaner for cuttlefish/pretty

This change adds a .clang-tidy symlink to cuttlefish/pretty that enables misc-include-cleaner, registers it in BUILD.bazel, and fixes the resulting lint errors.

Bug: b/523396865
Assisted-by: Jetski:GeminiNext

Author: Databean

base/cvd/BUILD.bazel

@@ -27,7 +27,6 @@ filegroup(
     name = "clang_tidy_config",
     srcs = [
         ".clang-tidy",
-        "//cuttlefish/io:.clang-tidy",
         "//cuttlefish/common/libs/key_equals_value:.clang-tidy",
         "//cuttlefish/flag_parser:.clang-tidy",
         "//cuttlefish/host/commands/assemble_cvd/android_build:.clang-tidy",
@@ -40,6 +39,8 @@ filegroup(
         "//cuttlefish/host/libs/web:.clang-tidy",
         "//cuttlefish/host/libs/zip:.clang-tidy",
         "//cuttlefish/host/libs/zip/libzip_cc:.clang-tidy",
+        "//cuttlefish/io:.clang-tidy",
+        "//cuttlefish/pretty:.clang-tidy",
     ],
 )
 

base/cvd/cuttlefish/pretty/.clang-tidy

@@ -0,0 +1 @@
+../../clang_tidy_configs/with_include_cleaner

base/cvd/cuttlefish/pretty/BUILD.bazel

@@ -4,6 +4,8 @@ package(
     default_visibility = ["//:android_cuttlefish"],
 )
 
+exports_files([".clang-tidy"])
+
 cf_cc_library(
     name = "container",
     srcs = ["container.cc"],

base/cvd/cuttlefish/pretty/container.cc

@@ -20,6 +20,8 @@
 #include <string_view>
 #include <vector>
 
+#include "absl/strings/str_cat.h"
+#include "absl/strings/str_format.h"
 #include "absl/strings/str_replace.h"
 
 namespace cuttlefish {

base/cvd/cuttlefish/pretty/container_test.cc

@@ -16,10 +16,12 @@
 
 #include "cuttlefish/pretty/container.h"
 
+#include <sstream>
 #include <string_view>
 #include <vector>
 
 #include "absl/strings/ascii.h"
+#include "absl/strings/str_cat.h"
 #include "fmt/format.h"
 #include "gtest/gtest.h"
 

base/cvd/cuttlefish/pretty/json.cc

@@ -15,6 +15,8 @@
 
 #include "cuttlefish/pretty/json.h"
 
+#include <string>
+
 #include "json/value.h"
 #include "json/writer.h"
 

base/cvd/cuttlefish/pretty/json_test.cc

@@ -16,6 +16,8 @@
 
 #include "cuttlefish/pretty/json.h"
 
+#include <string>
+
 #include "absl/strings/match.h"
 #include "gtest/gtest.h"
 #include "json/value.h"

base/cvd/cuttlefish/pretty/liblp/builder.cc

@@ -18,10 +18,9 @@
 #include "liblp/builder.h"
 
 #include "cuttlefish/pretty/pretty.h"
-#include "cuttlefish/pretty/string.h"
 #include "cuttlefish/pretty/struct.h"
-#include "cuttlefish/pretty/unique_ptr.h"
-#include "cuttlefish/pretty/vector.h"
+#include "cuttlefish/pretty/unique_ptr.h"  // IWYU pragma: keep
+#include "cuttlefish/pretty/vector.h"      // IWYU pragma: keep
 
 namespace cuttlefish {
 

base/cvd/cuttlefish/pretty/liblp/liblp.cc

@@ -17,10 +17,10 @@
 
 #include "liblp/liblp.h"
 
-#include "cuttlefish/pretty/liblp/metadata_format.h"
+#include "cuttlefish/pretty/liblp/metadata_format.h"  // IWYU pragma: keep
 #include "cuttlefish/pretty/pretty.h"
 #include "cuttlefish/pretty/struct.h"
-#include "cuttlefish/pretty/vector.h"
+#include "cuttlefish/pretty/vector.h"  // IWYU pragma: keep
 
 namespace cuttlefish {
 

base/cvd/cuttlefish/pretty/liblp/metadata_format.cc

@@ -15,13 +15,15 @@
 
 #include "cuttlefish/pretty/liblp/metadata_format.h"
 
+#include <cstdint>
+#include <vector>
+
 #include "liblp/liblp.h"
 #include "liblp/metadata_format.h"
 
 #include "cuttlefish/pretty/pretty.h"
-#include "cuttlefish/pretty/string.h"
 #include "cuttlefish/pretty/struct.h"
-#include "cuttlefish/pretty/vector.h"
+#include "cuttlefish/pretty/vector.h"  // IWYU pragma: keep
 
 namespace cuttlefish {
 namespace {