Fixed abnoma Alpha of output img. Fixed a potential issues. #8
Open
NoonieBao wants to merge 3 commits into
Open
Fixed abnoma Alpha of output img. Fixed a potential issues. #8NoonieBao wants to merge 3 commits into
NoonieBao wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a long-standing potential issue: when
Image_Tester.pyis not executed in advance and there are unsafe images, which lead to abnormal output.The line
avgs.append(getAverageRGB(img))in case of an exception will result in the length ofavgsbeing less than the length ofinput_images, causing index confusion and abnormal output.Fixed incorrect alpha blending.
For example, two pixels that are not totally opaque (less than 255), no matter how they are overlaid, will remain not totally opaque. Therefore, we always output as RGB (jpeg).
Optimization coding. Since the script only consider the RGB channels when matching images, we can set and blend the alpha channel at the end to enhance code readability.