Commit 146b553
committed
fix(h02/h16/h22): H23 dropdown defaulted to fp32 overriding H02 toggle
H23 added top-bar-precision-mode dropdown defaulting to "fp32",
which forwarded master_dtype="fp32" on every Train and silently
overrode the mixed_precision checkbox (H02) — only surfaced when
running the V6 e2e suite in one sweep.
Fix:
- Add "auto" as the first dropdown option (default) that means
"defer to spec.optim.mixed_precision" (the H02 wire).
- App.handleRunPipeline now only forwards opts.master_dtype when
!== "auto".
- H22 spec relaxed to assert via the always-visible
top-bar-train-status badge instead of trying to re-open the
dropdown after the modal appears.
V6 e2e suite re-run after fix: H02/H16/H23 + H22 all pass.1 parent 4cfccf1 commit 146b553
3 files changed
Lines changed: 18 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
350 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
351 | 352 | | |
352 | 353 | | |
353 | 354 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
51 | 53 | | |
52 | | - | |
| 54 | + | |
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| |||
220 | 222 | | |
221 | 223 | | |
222 | 224 | | |
223 | | - | |
| 225 | + | |
| 226 | + | |
224 | 227 | | |
225 | 228 | | |
226 | 229 | | |
| |||
0 commit comments