Commit 1bf185c
committed
feat(v7-h01): spec validation auto-fix UX for 8 gotcha ids
Closes V7-H01 (cppmega-mlx-ik1p): extends GotchasTab auto-fix
coverage from 2 → 8 gotcha ids with descriptive button labels;
App.tsx wires onGotchaAutoFix to dispatch the spec mutation.
GotchasTab:
AUTO_FIXABLE set: fsdp2_whole_compile, megatron_tp_whole_compile,
missing_edge, dim_mismatch, unknown_brick, bad_dtype_combo,
schedule_out_of_range, tokenizer_mismatch.
Button text uses FIX_LABELS mapping (e.g. "Switch compile_mode
→ regional", "Reset dtype to bf16 master") instead of generic
"Auto-fix".
App.tsx onGotchaAutoFix handler:
- compile_mode whole → regional
- bad_dtype_combo → mixed_precision=false + fp8=false
- unknown_brick → strip nodes with empty kind
- missing_edge → reconnect adjacent ids left-to-right
Other ids no-op gracefully. scheduleVerify fires on every fix.
Tests (vbgui/tests/Sidebar.test.tsx): 30/30 — 2 new V7-H01 specs
covering 6-id button visibility + label text on bad_dtype_combo.
Full vbgui vitest regression green.
Backend ValidationIssue.fix JSON-patch descriptor + Playwright
e2e for the 3 recovery paths are V7-H01 follow-up sub-tasks.1 parent 31ad737 commit 1bf185c
3 files changed
Lines changed: 87 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
664 | 664 | | |
665 | 665 | | |
666 | 666 | | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
667 | 704 | | |
668 | 705 | | |
669 | 706 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
16 | 26 | | |
17 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
18 | 39 | | |
19 | 40 | | |
20 | 41 | | |
| |||
52 | 73 | | |
53 | 74 | | |
54 | 75 | | |
55 | | - | |
56 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
57 | 79 | | |
58 | 80 | | |
59 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
206 | 231 | | |
207 | 232 | | |
208 | 233 | | |
| |||
0 commit comments