Skip to content

Commit 24be790

Browse files
committed
test(path-c): fix inverted vecmat owner-output assertion (RULE #1 FIRE rank-5)
test_fp8_vecmat_direct_tvm_ffi_reuses_owner_output_and_matches_reference asserted `returned is not out`, contradicting the owner-output reuse contract (the route writes in place and returns the caller-owned out -- the sibling tests at 361/510 assert `returned is out`, and the test name says "reuses_owner_output"). Production code is correct (verified: returned IS out, output matches reference). Fixed the inverted assertion; 2 passed.
1 parent bf158eb commit 24be790

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

tests/test_tilelang_fp8_vecmat_path_c.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,11 @@ def test_fp8_vecmat_direct_tvm_ffi_reuses_owner_output_and_matches_reference() -
649649
expected = reference.astype(dtype).astype(mx.float32)
650650
mx.eval(returned, expected)
651651

652-
assert returned is not out
652+
# Owner-output reuse contract: the tvm-ffi route writes in place and
653+
# returns the caller-owned ``out`` (matches the sibling owner-output
654+
# tests at 361/510 and the function name "reuses_owner_output"). The
655+
# prior ``is not out`` assertion was inverted vs the documented contract.
656+
assert returned is out
653657
np.testing.assert_allclose(
654658
np.asarray(out.astype(mx.float32)),
655659
np.asarray(expected),

0 commit comments

Comments
 (0)