Commit 70792af
committed
fix(v7-q11): inspect.histogram Invalid params + brick_<kind> alias for adapter help
Two issues surfaced on the canvas rmsnorm node:
1. Inspect-weight-histogram → "Invalid params"
The UI was sending the full buildVerifyParams payload as the spec
arg to inspect.histogram. On certain canvas states (custom
tiny_aya parallel composition, missing loss head outputs, etc.)
the full payload failed VerifyParams' extra='forbid' validation
before the backend handler ran. Backend works fine on a minimal
spec — the inspect call only needs spec.graph.nodes[*].{id,kind,
params} + spec.dim_env.H to instantiate the brick.
Fix: build a minimal spec containing JUST the target brick + the
current dim_env + a placeholder loss/optim that satisfies the
schema. Verified end-to-end on rmsnorm/attention/mlp via the
existing pytest histogram suite (10/10 PASS).
2. BrickContextPanel HelpModal → "(No explanation for brick_rmsnorm yet.)"
Q09 shipped 25 brick_<kind> entries (covering the BRICKS array)
and 6 adapter_<kind> entries (rmsnorm/residual/merge_heads/etc.).
But adapter kinds also appear as nodes on the canvas, and the
BrickContextPanel looks up help under brick_<kind> regardless of
array origin.
Fix: alias every adapter_<kind> entry to brick_<kind> at module
load. No content duplication — both keys reference the same
HelpTopic object.
Tests (all green):
- vbgui/tests/HelpIconAdapterAlias.test.tsx: 3 cases — alias map
populated, brick_rmsnorm modal opens with RMSNorm content
- pytest tests/v4/ -k histogram: 10/10 PASS (no backend regression)
- vbgui vitest full: 483 -> 509 (+26) PASS1 parent d6efa99 commit 70792af
3 files changed
Lines changed: 94 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1933 | 1933 | | |
1934 | 1934 | | |
1935 | 1935 | | |
1936 | | - | |
1937 | | - | |
1938 | | - | |
| 1936 | + | |
| 1937 | + | |
| 1938 | + | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
| 1943 | + | |
1939 | 1944 | | |
1940 | | - | |
1941 | | - | |
1942 | | - | |
| 1945 | + | |
| 1946 | + | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
| 1951 | + | |
| 1952 | + | |
| 1953 | + | |
| 1954 | + | |
| 1955 | + | |
| 1956 | + | |
| 1957 | + | |
| 1958 | + | |
| 1959 | + | |
| 1960 | + | |
| 1961 | + | |
| 1962 | + | |
| 1963 | + | |
| 1964 | + | |
| 1965 | + | |
| 1966 | + | |
| 1967 | + | |
| 1968 | + | |
| 1969 | + | |
| 1970 | + | |
| 1971 | + | |
| 1972 | + | |
| 1973 | + | |
| 1974 | + | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
| 1978 | + | |
1943 | 1979 | | |
1944 | 1980 | | |
1945 | 1981 | | |
1946 | 1982 | | |
1947 | 1983 | | |
1948 | 1984 | | |
1949 | | - | |
| 1985 | + | |
1950 | 1986 | | |
1951 | 1987 | | |
1952 | 1988 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
874 | 875 | | |
875 | 876 | | |
876 | 877 | | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
877 | 894 | | |
878 | 895 | | |
879 | 896 | | |
| |||
892 | 909 | | |
893 | 910 | | |
894 | 911 | | |
895 | | - | |
896 | | - | |
897 | | - | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
898 | 915 | | |
| 916 | + | |
899 | 917 | | |
900 | 918 | | |
901 | 919 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
0 commit comments