Skip to content

Commit 8b6d74b

Browse files
committed
ci: use isolated MLX build dependencies
1 parent ce3681a commit 8b6d74b

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/e2e-matrix.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
- name: Python deps
5757
run: |
5858
"$VBGUI_E2E_PYTHON" -m pip install --disable-pip-version-check \
59-
--no-build-isolation -e ".[gui,parquet,widget]"
59+
-e ".[gui,parquet,widget]"
6060
- name: Generate fixtures
6161
run: |
6262
"$VBGUI_E2E_PYTHON" tests/fixtures/build_e2e_matrix.py
@@ -111,7 +111,7 @@ jobs:
111111
echo "VBGUI_E2E_PYTHON=$job_venv/bin/python" >> "$GITHUB_ENV"
112112
- run: |
113113
"$VBGUI_E2E_PYTHON" -m pip install --disable-pip-version-check \
114-
--no-build-isolation -e ".[gui,parquet,widget]"
114+
-e ".[gui,parquet,widget]"
115115
- run: |
116116
"$VBGUI_E2E_PYTHON" tests/fixtures/build_e2e_matrix.py
117117
- working-directory: vbgui
@@ -161,7 +161,7 @@ jobs:
161161
echo "VBGUI_E2E_PYTHON=$job_venv/bin/python" >> "$GITHUB_ENV"
162162
- run: |
163163
"$VBGUI_E2E_PYTHON" -m pip install --disable-pip-version-check \
164-
--no-build-isolation -e ".[gui,parquet,widget]"
164+
-e ".[gui,parquet,widget]"
165165
- run: |
166166
"$VBGUI_E2E_PYTHON" tests/fixtures/build_e2e_matrix.py
167167
- working-directory: vbgui

tests/test_workflow_runner_policy.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ def test_macos_e2e_uses_an_isolated_job_venv() -> None:
6363

6464
assert "pip install --upgrade pip" not in workflow
6565
assert workflow.count("-m venv --system-site-packages") == 3
66-
assert workflow.count("--no-build-isolation -e") == 3
66+
assert "--no-build-isolation" not in workflow
67+
assert workflow.count('-e ".[gui,parquet,widget]"') == 3
6768
assert workflow.count('echo "VBGUI_E2E_PYTHON=$job_venv/bin/python"') == 3
6869

6970

0 commit comments

Comments
 (0)