Skip to content

Commit c121b80

Browse files
committed
ci: remove self-hosted npm cache upload
1 parent f80c081 commit c121b80

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

.github/workflows/e2e-matrix.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ jobs:
5252
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
5353
with:
5454
node-version: "22"
55-
cache: "npm"
56-
cache-dependency-path: vbgui/package-lock.json
5755
- name: Create isolated MLX Python
5856
run: |
5957
base_python=/Volumes/external/sources/cppmega.mlx/.venv/bin/python
@@ -119,8 +117,7 @@ jobs:
119117
steps:
120118
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
121119
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
122-
with: { node-version: "22", cache: "npm",
123-
cache-dependency-path: vbgui/package-lock.json }
120+
with: { node-version: "22" }
124121
- name: Create isolated MLX Python
125122
run: |
126123
base_python=/Volumes/external/sources/cppmega.mlx/.venv/bin/python
@@ -178,8 +175,7 @@ jobs:
178175
steps:
179176
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
180177
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
181-
with: { node-version: "22", cache: "npm",
182-
cache-dependency-path: vbgui/package-lock.json }
178+
with: { node-version: "22" }
183179
- name: Create isolated MLX Python
184180
run: |
185181
base_python=/Volumes/external/sources/cppmega.mlx/.venv/bin/python

docs/self_hosted_ci.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,4 +118,9 @@ sharding assigned all 912 tests to shard 1 while the other shards had no tests.
118118
The self-hosted workflow now passes `--fully-parallel`, retaining four shards
119119
that contain test cells rather than files. Playwright has a 12-minute global
120120
cap and each job has a 20-minute cap, leaving setup and artifact-upload
121-
headroom while still producing logs on a test timeout.
121+
headroom while still producing logs on a test timeout. Corrected run
122+
`29306678792` also exposed a 1.9 GB `setup-node` cache-save attempt after shard
123+
2 had passed; it spent 101 seconds packing the cache and then failed to reserve
124+
the key. GitHub's npm cache hook is disabled for these persistent runners;
125+
npm's host-local cache remains available to `npm ci` without a remote post-job
126+
upload.

tests/test_workflow_runner_policy.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ def test_preset_matrix_is_really_sharded_and_bounded() -> None:
144144
assert "--shard=${{ matrix.shard }}/4" in preset_job
145145
assert "timeout-minutes: 20" in preset_job
146146
assert "timeout-minutes: 40" not in preset_job
147+
assert 'cache: "npm"' not in workflow
148+
assert "cache-dependency-path:" not in workflow
147149

148150

149151
def test_core_self_hosted_jobs_use_the_shared_receipted_lane_runner() -> None:

0 commit comments

Comments
 (0)