Skip to content

Commit dd77ca2

Browse files
committed
fix(v7-f56b): badge no longer intercepts pointer events on DimEnvEditor
The absolutely-positioned symbolic-dim-warn-badge sat over the right edge of the DimEnvEditor row (top:8, right:8), which intercepted clicks on the Apply button when the badge was visible. The e2e restoration step (apply consistent values to clear the warning) could not click through. vbgui/src/App.tsx: - pointerEvents: 'none' on the badge — it's purely informational. - top: 44 (instead of 8) so the badge clearly sits below the editor bar rather than overlapping it. Playwright e2e/scenarios/56_symbolic_dim_warn.spec.ts passes 1/1 (1.1s) with real backend + frontend roundtrip — closes the F56b visual-e2e acceptance criterion: typing nh=3 surfaces the live mismatch indicator, Apply triggers the verify roundtrip, the canvas badge renders with the correct H and nh*head_dim product, and restoring nh=2 clears the badge after the next verify. Ref: cppmega-mlx-j3qa.2
1 parent 114ab12 commit dd77ca2

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

vbgui/src/App.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -650,13 +650,16 @@ export function App(): JSX.Element {
650650
data-testid="symbolic-dim-warn-badge"
651651
role="alert"
652652
style={{
653-
position: "absolute", top: 8, right: 8, zIndex: 5,
653+
position: "absolute", top: 44, right: 8, zIndex: 5,
654654
background: "#fef3c7", color: "#92400e",
655655
borderLeft: "4px solid #d97706",
656656
borderRadius: 4, padding: "6px 10px",
657657
fontSize: 12, fontFamily: "system-ui, sans-serif",
658658
boxShadow: "0 1px 2px rgba(0,0,0,0.08)",
659659
maxWidth: 320,
660+
// Badge is informational; never block clicks
661+
// on the DimEnvEditor Apply button beneath.
662+
pointerEvents: "none",
660663
}}
661664
>
662665
<strong data-testid="symbolic-dim-warn-title">

0 commit comments

Comments
 (0)