Skip to content

Commit fa2f4d9

Browse files
committed
fix: bind sidecar objectives to v2 materialization
1 parent 5e40cbe commit fa2f4d9

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

scripts/sidecar_manifest_contract.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,13 @@
2424
"pr": (1024, 2048, 4096, 8192, 16384),
2525
}
2626
OBJECTIVE_CONTRACT = {
27-
"schema": "cppmega_mlx_runtime_objectives_v1",
28-
"status": "runtime_materialized",
27+
"schema": "cppmega_mlx_objective_source_v2",
28+
"status": "source_for_pre_materialization",
2929
"materialized_in_parquet": False,
30-
"runtime": "cppmega_mlx.training.task_mixer.TaskMixer",
30+
"materializer": "scripts.materialize_megatron_objectives",
31+
"planner": "cppmega_mlx.training.objective_schedule.CanonicalObjectivePlanner",
32+
"mixer": "cppmega_mlx.training.objective_mixer.EligibilityAwareTaskMixer",
33+
"artifact_schema": "cppmega_objective_materialization_artifact_v2",
3134
"stage": "stage1",
3235
"rates": {
3336
"causal_lm": "1/2",

tests/test_case6_sidecar_manifest_contract.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,19 @@ def test_manifest_binds_inventory_and_explicit_bucket_exclusions(tmp_path: Path)
116116
}
117117

118118

119+
def test_objective_manifest_is_explicitly_a_source_for_v2_materialization() -> None:
120+
assert OBJECTIVE_CONTRACT["schema"] == "cppmega_mlx_objective_source_v2"
121+
assert OBJECTIVE_CONTRACT["status"] == "source_for_pre_materialization"
122+
assert OBJECTIVE_CONTRACT["materialized_in_parquet"] is False
123+
assert OBJECTIVE_CONTRACT["materializer"] == (
124+
"scripts.materialize_megatron_objectives"
125+
)
126+
assert OBJECTIVE_CONTRACT["artifact_schema"] == (
127+
"cppmega_objective_materialization_artifact_v2"
128+
)
129+
assert "TaskMixer" not in str(OBJECTIVE_CONTRACT.get("runtime", ""))
130+
131+
119132
def test_manifest_rejects_payload_tampering(tmp_path: Path) -> None:
120133
manifest, _root = _green_manifest(tmp_path)
121134
tampered = copy.deepcopy(manifest)

0 commit comments

Comments
 (0)