Reimplement Berlin and Brandenburg spiders#180
Merged
k-nut merged 6 commits intoDatenschule:mainfrom Jul 6, 2025
Merged
Conversation
k-nut
reviewed
Jul 3, 2025
Member
k-nut
left a comment
k-nut
left a comment
There was a problem hiding this comment.
Looks really good all in all. Just a couple of questions and comments :)
Member
|
This looks good to me overall. It's just that the test_changes script seems not to work right now. I'd love to see it run once just to be 100% sure that no data changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.