Skip to content

[RP] Use data from Geoportal#223

Closed
SimonMand wants to merge 3 commits intomainfrom
193_rework_rheinland_spider
Closed

[RP] Use data from Geoportal#223
SimonMand wants to merge 3 commits intomainfrom
193_rework_rheinland_spider

Conversation

@SimonMand
Copy link
Copy Markdown
Collaborator

@SimonMand SimonMand commented Oct 31, 2025

Some changes from the original impl:

Number of schools is a bit less:
Rheinland-pfalz: 1653
Rheinland-pfalz (new way): 1629

Some parameters per school are missing:
website
provider
fax

Runtime is significantly faster. Instead on ~30 seconds, now it's ~2 seconds

Fixes #193

@k-nut
Copy link
Copy Markdown
Member

k-nut commented Nov 3, 2025

Hm, I somehow seem to have forgotten that we did have a way for getting geo data for RP already when I created #193. I'm not sure if this is worth the change now that I see the difference. It's nice since the code is a bit simpler but I'd argue that we are actually only losing information right now without much added benefit. What do you think @SimonMand? (code changes themselves look good 👍)

@SimonMand
Copy link
Copy Markdown
Collaborator Author

What do you think @SimonMand? (code changes themselves look good 👍)

I totally agree with you. The HTML flow gives us more information and same coordinates. So I would stick with what we have.
I will close this PR as it is obsolete now. And will prepare a new PR to update the table (from NO -> YES)

@k-nut
Copy link
Copy Markdown
Member

k-nut commented Nov 4, 2025

That sounds like a good plan. Thank you!

@SimonMand SimonMand closed this Nov 5, 2025
@SimonMand
Copy link
Copy Markdown
Collaborator Author

The PR was closed, because it's offering less data and for locations then we already have them from the original HTML api.

@k-nut
Copy link
Copy Markdown
Member

k-nut commented Apr 8, 2026

For future reference, I've updated our table in 1953db0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RP] Use data from Geoportal

2 participants