Conversation
|
Hm, I somehow seem to have forgotten that we did have a way for getting geo data for RP already when I created #193. I'm not sure if this is worth the change now that I see the difference. It's nice since the code is a bit simpler but I'd argue that we are actually only losing information right now without much added benefit. What do you think @SimonMand? (code changes themselves look good 👍) |
I totally agree with you. The HTML flow gives us more information and same coordinates. So I would stick with what we have. |
|
That sounds like a good plan. Thank you! |
|
The PR was closed, because it's offering less data and for locations then we already have them from the original HTML api. |
|
For future reference, I've updated our table in 1953db0 |
Some changes from the original impl:
Number of schools is a bit less:
Rheinland-pfalz: 1653
Rheinland-pfalz (new way): 1629
Some parameters per school are missing:
website
provider
fax
Runtime is significantly faster. Instead on ~30 seconds, now it's ~2 seconds
Fixes #193