Only use uv to generate lockfiles#73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current release
ducktools-envwill useuvto install packages and possibly Python runtimes. This PR moves away from that to usingpipalways even ifuvis available.This is partly a maintenance issue, it's easier to know the pip fallback works if the pip fallback is just the method. Given this is what would be used if the user did not have
uvit makes more sense to keep this method, even if the install is slightly slower. If the environment is cached, neitherpipnoruvare used so it only matters when new environments are constructed.The only place where there isn't equivalent functionality from
pipor the stdlib is for generating universal lockfiles. In this caseuvis still required at present.Functionally the main difference this makes is that
ducktools-envwill no longer install uv python runtimes automatically. It's debatable whether it was a good idea to do that in the first place.