more psalm fixes

Author: DavidGoodwin

include/UserAdmin.php

@@ -306,7 +306,7 @@ public function check_access(string $homedir, int $uid, int $gid) : string
             $fuid = fileowner($homedir);
             $fgid = filegroup($homedir);
             $fperms = fileperms($homedir);
-            $fperm = substr(sprintf("%o", $fperms), 2);
+            $fperm = substr(sprintf("%o", (string) $fperms), 2);
             $rights["owner"] = substr($fperm, 0, 1);
             $rights["group"] = substr($fperm, 1, 1);
             $rights["world"] = substr($fperm, 2, 1);

psalm.xml

@@ -17,12 +17,6 @@
 
         <!-- level 3 issues - slightly lazy code writing, but provably low false-negatives -->
 
-        <DeprecatedMethod errorLevel="info" />
-        <DeprecatedProperty errorLevel="info" />
-        <DeprecatedClass errorLevel="info" />
-        <DeprecatedConstant errorLevel="info" />
-        <DeprecatedInterface errorLevel="info" />
-        <DeprecatedTrait errorLevel="info" />
 
         <InternalMethod errorLevel="info" />
         <InternalProperty errorLevel="info" />
@@ -37,7 +31,6 @@
         <RedundantCondition errorLevel="info" /> 
         <RedundantConditionGivenDocblockType errorLevel="info" />
 
-
         <DocblockTypeContradiction errorLevel="info" />
         <TypeDoesNotContainType errorLevel="info" />
 

public/index.php

@@ -55,7 +55,10 @@
                     $flash->info("User emailed");
                     $with_password = $values;
                     $with_password['password'] = $_POST['password'];
-                    $model->sendPostCreationEmail($with_password);
+                    $success = $model->sendPostCreationEmail($with_password);
+                    if(!$success) {
+                        $flash->error("Email may not have been sent.");
+                    }
                 }
                 $form = new PureFTPAdmin\Form\User();
             }