fix(DecryptedText): cancel in-flight animation on mouseleave in DecryptedText#933
Open
junijaei wants to merge 1 commit intoDavidHDev:mainfrom
Open
fix(DecryptedText): cancel in-flight animation on mouseleave in DecryptedText#933junijaei wants to merge 1 commit intoDavidHDev:mainfrom
junijaei wants to merge 1 commit intoDavidHDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rapid hover on/off the
DecryptedTextcomponent intermittently caused stalesetIntervalcallbacks to keep firing aftermouseleave, resulting in overlapping animations and broken reset behavior.Root Cause
The interval ID was stored in a local variable inside the
useEffect, sotriggerHoverDecryptandresetToPlainTexthad no reference to it and could not cancel it on hover exit.Fix
intervalRefso it is accessible outside the effect.resetToPlainTextnow cancels the active interval before clearing state.Changes
All 4 component variants updated
src/content/TextAnimations/DecryptedText/DecryptedText.jsxsrc/tailwind/TextAnimations/DecryptedText/DecryptedText.jsxsrc/ts-default/TextAnimations/DecryptedText/DecryptedText.tsxsrc/ts-tailwind/TextAnimations/DecryptedText/DecryptedText.tsxRegistry artifacts regenerated
public/r/DecryptedText-JS-CSS.jsonpublic/r/DecryptedText-JS-TW.jsonpublic/r/DecryptedText-TS-CSS.jsonpublic/r/DecryptedText-TS-TW.jsonBefore
After
Testing