Skip to content

fix: replace live-server with serve to resolve Snyk vulnerabilities#147

Merged
DavidKRK merged 3 commits into
gh-pagesfrom
copilot/fix-snyk-pr-checks-issue
Apr 4, 2026
Merged

fix: replace live-server with serve to resolve Snyk vulnerabilities#147
DavidKRK merged 3 commits into
gh-pagesfrom
copilot/fix-snyk-pr-checks-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026

  • Investigate Snyk PR check vulnerabilities
  • Replace live-server with serve to eliminate 11 vulnerabilities
  • Update dev script to use serve
  • Regenerate package-lock.jsonnpm audit reports 0 vulnerabilities
  • Remove node_modules/.package-lock.json from git tracking (npm-generated artifact, should not be committed)

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 4, 2026

Deploy Preview for whimsical-kitsune-85066d ready!

Name Link
🔨 Latest commit 5a98d31
🔍 Latest deploy log https://app.netlify.com/projects/whimsical-kitsune-85066d/deploys/69d077c2cf3d4e0008b56dbc
😎 Deploy Preview https://deploy-preview-147--whimsical-kitsune-85066d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 4, 2026

Deploy Preview for spiffy-liger-8bab58 ready!

Name Link
🔨 Latest commit 5a98d31
🔍 Latest deploy log https://app.netlify.com/projects/spiffy-liger-8bab58/deploys/69d077c24a2b490008bec44d
😎 Deploy Preview https://deploy-preview-147--spiffy-liger-8bab58.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces live-server with serve in the project’s development tooling to eliminate unfixable transitive vulnerabilities and updates lockfiles accordingly.

Changes:

  • Swap live-server@^1.2.0serve@^14.2.6 in devDependencies.
  • Update the dev script to use serve on port 8080.
  • Regenerate package-lock.json to reflect the new dependency tree.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Replaces live-server with serve and updates the dev script accordingly.
package-lock.json Updates the dependency graph to remove live-server and its transitive dependencies.
node_modules/.package-lock.json Updated npm-generated lock artifact under node_modules/ (should not be tracked).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread node_modules/.package-lock.json Outdated
@DavidKRK DavidKRK marked this pull request as ready for review April 4, 2026 02:28
@DavidKRK
Copy link
Copy Markdown
Owner

DavidKRK commented Apr 4, 2026

@copilot @copilot Peux-tu exécuter les actions que tu m'as proposé précédemment ?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 4, 2026

@copilot @copilot Peux-tu exécuter les actions que tu m'as proposé précédemment ?

Done in commit 5a98d31. node_modules/.package-lock.json has been removed from git tracking with git rm --cached. Since node_modules is already in .gitignore, this file will no longer appear in future diffs or commits.

Copilot AI requested a review from DavidKRK April 4, 2026 02:30
Copy link
Copy Markdown
Owner

@DavidKRK DavidKRK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot donne un résumer

@DavidKRK
Copy link
Copy Markdown
Owner

DavidKRK commented Apr 4, 2026

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 4, 2026

@copilot donne un résumer

Voici un résumé de ce PR :

Problème : live-server@1.2.x embarquait 11 vulnérabilités transitives non corrigeables (7 élevées, 4 modérées) — principalement des ReDoS dans debug, ms, micromatch, braces et picomatch.

Solution :

  • live-server@^1.2.0serve@^14.2.6 dans devDependencies
  • Script dev mis à jour : npx live-server --port=8080npx serve --listen 8080
  • package-lock.json regénéré — supprime ~193 paquets vulnérables ; npm audit signale désormais 0 vulnérabilité
  • node_modules/.package-lock.json retiré du suivi git (artefact généré par npm, ne devait pas être versionné)

@copilot apply changes based on the comments in this thread

Already done. The only actionable change in that review thread was removing node_modules/.package-lock.json from git tracking, which was applied in commit 5a98d31 (git rm --cached node_modules/.package-lock.json). The thread is now marked as resolved.

Copilot AI requested a review from DavidKRK April 4, 2026 03:44
@DavidKRK DavidKRK merged commit 2b66a7a into gh-pages Apr 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants