Skip to content

chore: expand PR template with structured review sections #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidKRK merged 3 commits into from
Apr 4, 2026
Merged

chore: expand PR template with structured review sections #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
227ac8d
chore: update PR template with comprehensive sections
Copilot Apr 4, 2026
8213da5
fix: add Buy Me A Coffee icon to bio, music, and event pages
Copilot Apr 4, 2026
f06ecb6
fix: footer and meta tag consistency across all pages
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 69 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,77 @@ assignees: ''

---

**Description des changements**
## 1. Quels sont les changements ?

(Décrivez ici les changements que vous proposez.)
**Résumé des changements :**

**Issue liée**
(Décrivez brièvement les modifications apportées.)

(Lien vers l'issue correspondante, s'il y en a une. Par exemple : "Closes #123")
**Tickets / Issues liés :**

**Informations supplémentaires**
- Closes #<!-- numéro de l'issue -->
- Ref #<!-- autre ticket lié, si applicable -->

Comment thread
DavidKRK marked this conversation as resolved.
(Ajoutez ici tout autre contexte ou capture d'écran concernant la pull request.)
---

## 2. Pourquoi ces changements ?

**Contexte métier :**

(Expliquez la raison fonctionnelle ou business de ces changements.)

**Justification technique :**

(Expliquez les choix d'architecture ou d'implémentation retenus.)

---

## 3. Tests

**Tests unitaires :**
- [ ] Nouveaux tests ajoutés
- [ ] Tests existants mis à jour
- [ ] Tous les tests passent (`npm test` / `bundle exec rspec` / …)

**Tests manuels :**
- [ ] Testé en local
- [ ] Testé sur un environnement de staging / preview

**Performances & Sécurité :**
- [ ] Impact sur les performances évalué
- [ ] Aucune vulnérabilité introduite (dépendances, injection, XSS, …)

---

## 4. Changements majeurs (Breaking Changes)

**Cette PR introduit-elle des ruptures d'API ou de comportement ?**

- [ ] Non
- [ ] Oui — détails ci-dessous :

(Décrivez les ruptures et les impacts pour les consommateurs de l'API / les autres équipes.)

**Instructions de migration :**

(Si applicable, décrivez les étapes nécessaires pour migrer.)

---

## 5. Exigences de déploiement

- [ ] Migrations de base de données à exécuter
- [ ] Nouvelles variables d'environnement à configurer (listez-les ci-dessous)
- [ ] Feature flags à activer / désactiver
- [ ] Services tiers à configurer ou notifier
- [ ] Documentation mise à jour

**Variables d'environnement :**

| Variable | Description | Valeur par défaut |
|----------|-------------|-------------------|
| `NOM_VAR` | Description | `valeur` |

**Notes de déploiement supplémentaires :**

(Toute information utile pour l'équipe de déploiement.)
3 changes: 2 additions & 1 deletion bio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,11 @@ <h2 class="main-title">Bio</h2>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-mixcloud"></i></a>
<a href="https://www.youtube.com/@DavidKRKofficial" target="_blank" aria-label="YouTube"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-youtube"></i></a>
<a href="https://soundcloud.com/david-krkofficial" target="_blank" aria-label="SoundCloud"
<a href="https://soundcloud.com/david-krkofficial/" target="_blank" aria-label="SoundCloud"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 30px;"></a>
Comment thread
DavidKRK marked this conversation as resolved.
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
1 change: 1 addition & 0 deletions event.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ <h1 class="main-title">David KRK</h1>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 30px;"></a>
Comment thread
DavidKRK marked this conversation as resolved.
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
16 changes: 16 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@
<title>David KRK · HOME</title>
<meta name="description" content="Site officiel de David KRK, DJ et producteur international de musique Techno. Découvrez sa musique, sa biographie et ses événements.">
<meta name="keywords" content="David KRK, DJ techno, producteur, événements, musique">
<meta name="author" content="David KRK">

<!-- Open Graph / Facebook -->
<meta property="og:type" content="website">
<meta property="og:url" content="https://davidkrk.com/index.html">
<meta property="og:title" content="David KRK · HOME · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Site officiel de David KRK, DJ et producteur international de musique Techno. Découvrez sa musique, sa biographie et ses événements.">
<meta property="og:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/index.html">
<meta property="twitter:title" content="David KRK · HOME · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Site officiel de David KRK, DJ et producteur international de musique Techno. Découvrez sa musique, sa biographie et ses événements.">
<meta property="twitter:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">

<link rel="icon" type="image/png" href="logo-30-01-25.png">
<!-- Fonts + Icones -->
<link rel="preconnect" href="https://fonts.googleapis.com">
Expand Down
1 change: 1 addition & 0 deletions music.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ <h1 class="main-title">David KRK</h1>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 30px;"></a>
Comment thread
DavidKRK marked this conversation as resolved.
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
18 changes: 17 additions & 1 deletion shop.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@
<title>David KRK · SHOP</title>
<meta name="description" content="Boutique officielle de David KRK : T-shirt premium avec logo, disponible en plusieurs couleurs, frais de port inclus.">
<meta name="keywords" content="David KRK, boutique, t-shirt, merch, techno, shop">
<meta name="author" content="David KRK">

<!-- Open Graph / Facebook -->
<meta property="og:type" content="website">
<meta property="og:url" content="https://davidkrk.com/shop.html">
<meta property="og:title" content="David KRK · SHOP · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Boutique officielle de David KRK : T-shirt premium avec logo, disponible en plusieurs couleurs, frais de port inclus.">
<meta property="og:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/shop.html">
<meta property="twitter:title" content="David KRK · SHOP · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Boutique officielle de David KRK : T-shirt premium avec logo, disponible en plusieurs couleurs, frais de port inclus.">
<meta property="twitter:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">

<link rel="icon" type="image/png" href="logo-30-01-25.png">
<!-- Fonts + Icones -->
<link rel="preconnect" href="https://fonts.googleapis.com">
Expand Down Expand Up @@ -181,7 +197,7 @@ <h2 class="mt-4">Офіційний магазин</h2>
class="hover:text-[var(--primary-color)] transition-colors footer-contact-link">CONTACT | BOOKING | REMIX</a>
</div>

<p class="text-sm opacity-70">© <span id="copyright-year"></span> David KRK. All Rights Reserved</p>
<p class="text-sm opacity-70">© 2026 David KRK. All Rights Reserved</p>
<p class="neon-text font-bold text-lg mt-4">"May The Techno Be With You"</p>
</footer>
</div>
Expand Down
Loading