Skip to content

fix: security, accessibility, and og:image compatibility on social icons #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidKRK merged 3 commits into from
Apr 4, 2026
Merged

fix: security, accessibility, and og:image compatibility on social icons #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1d9be6
Initial plan
Copilot Apr 4, 2026
38cae14
fix: address review feedback - rel noopener, empty alt, PNG og:image
Copilot Apr 4, 2026
ea40b21
Update index.html
DavidKRK Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
<meta property="og:url" content="https://davidkrk.com/bio.html">
<meta property="og:title" content="David KRK · Bio · DJ Techno & Producteur">
<meta property="og:description" content="Biographie officielle de David KRK, DJ Techno international - France, Espagne, Pays Basque.">
<meta property="og:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="og:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/bio.html">
<meta property="twitter:title" content="David KRK · Bio · DJ Techno & Producteur">
<meta property="twitter:description" content="Biographie officielle de David KRK, DJ Techno international - France, Espagne, Pays Basque.">
<meta property="twitter:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="twitter:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Favicon -->
<link rel="icon" type="image/png" href="logo-30-01-25.png">
Expand Down Expand Up @@ -209,7 +209,7 @@ <h2 class="main-title">Bio</h2>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 1em; vertical-align: middle;"></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" style="height: 1em; vertical-align: middle;"></a>
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
6 changes: 3 additions & 3 deletions event.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
<meta property="og:url" content="https://davidkrk.com/event.html">
<meta property="og:title" content="David KRK · EVENTS · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Découvrez les prochains événements et dates de David KRK.">
<meta property="og:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="og:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/event.html">
<meta property="twitter:title" content="David KRK · EVENTS · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Découvrez les prochains événements et dates de David KRK.">
<meta property="twitter:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="twitter:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Favicon -->
<link rel="icon" type="image/png" href="logo-30-01-25.png">
Expand Down Expand Up @@ -98,7 +98,7 @@ <h1 class="main-title">David KRK</h1>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 1em; vertical-align: middle;"></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" style="height: 1em; vertical-align: middle;"></a>
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
6 changes: 3 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
<meta property="og:url" content="https://davidkrk.com/">
<meta property="og:title" content="David KRK · HOME · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Site officiel de David KRK, DJ et producteur international de musique Techno. Découvrez sa musique, sa biographie et ses événements.">
<meta property="og:image" content="https://davidkrk.com/images/optimized/logo.webp">
<meta property="og:image" content="https://davidkrk.com/logo-30-01-25.png">
Comment on lines 13 to +16

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description mentions expanding the PR template, but this change set updates site HTML meta tags and footer links. Please update the PR title/description to match the actual changes, or move these HTML changes into the intended PR and keep this PR focused on the template update.

Copilot uses AI. Check for mistakes.

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/">
<meta property="twitter:title" content="David KRK · HOME · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Site officiel de David KRK, DJ et producteur international de musique Techno. Découvrez sa musique, sa biographie et ses événements.">
<meta property="twitter:image" content="https://davidkrk.com/images/optimized/logo.webp">
<meta property="twitter:image" content="https://davidkrk.com/logo-30-01-25.png">

<link rel="icon" type="image/png" href="logo-30-01-25.png">
<!-- Fonts + Icones -->
Expand Down Expand Up @@ -126,7 +126,7 @@ <h1 class="main-title">David KRK</h1>
class="social-icon text-2xl md:text-3xl"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 30px;"></a><br>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" style="height: 1em; vertical-align: middle;"></a>
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
6 changes: 3 additions & 3 deletions music.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
<meta property="og:url" content="https://davidkrk.com/music.html">
<meta property="og:title" content="David KRK · MUSIC · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Découvrez la musique de David KRK, DJ et producteur de musique Techno.">
<meta property="og:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="og:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/music.html">
<meta property="twitter:title" content="David KRK · MUSIC · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Découvrez la musique de David KRK, DJ et producteur de musique Techno.">
<meta property="twitter:image" content="https://raw.githubusercontent.com/DavidKRK/DavidKRK.github.io/main/images/optimized/logo.webp">
<meta property="twitter:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Favicon -->
<link rel="icon" type="image/png" href="logo-30-01-25.png">
Expand Down Expand Up @@ -89,7 +89,7 @@ <h1 class="main-title">David KRK</h1>
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 1em; vertical-align: middle;"></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" style="height: 1em; vertical-align: middle;"></a>
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
8 changes: 3 additions & 5 deletions shop.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
<meta property="og:url" content="https://davidkrk.com/shop.html">
<meta property="og:title" content="David KRK · SHOP · DJ TECHNO & PRODUCER">
<meta property="og:description" content="Boutique officielle de David KRK : T-shirt premium avec logo, disponible en plusieurs couleurs, frais de port inclus.">
<meta property="og:image" content="https://davidkrk.com/images/optimized/logo.webp">
<meta property="og:image" content="https://davidkrk.com/logo-30-01-25.png">

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://davidkrk.com/shop.html">
<meta property="twitter:title" content="David KRK · SHOP · DJ TECHNO & PRODUCER">
<meta property="twitter:description" content="Boutique officielle de David KRK : T-shirt premium avec logo, disponible en plusieurs couleurs, frais de port inclus.">
<meta property="twitter:image" content="https://davidkrk.com/images/optimized/logo.webp">
<meta property="twitter:image" content="https://davidkrk.com/logo-30-01-25.png">

<link rel="icon" type="image/png" href="logo-30-01-25.png">
<!-- Fonts + Icones -->
Expand Down Expand Up @@ -187,9 +187,7 @@ <h2 class="mt-4">Офіційний магазин</h2>
class="social-icon text-2xl md:text-3xl"><i class="fab fa-soundcloud"></i></a>
<a href="https://www.tiktok.com/@davidkrk" target="_blank" aria-label="TikTok"
class="social-icon text-2xl md:text-3xl"><i class="fab fa-tiktok"></i></a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" aria-label="Buy Me A Coffee" class="social-icon">
<img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" style="height: 30px;">
</a>
<a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" style="height: 1em; vertical-align: middle;"></a>
</div>

<div class="flex flex-wrap justify-center items-center gap-3 sm:gap-4 mb-4 text-sm">
Expand Down
Loading