Fix invalid HTML structure (unclosed <main>, orphan </footer>) on index, contact, shop pages#162
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
DavidKRK
April 7, 2026 17:00
View session
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes malformed HTML on key pages by properly closing <main> and introducing a matching <footer> wrapper to eliminate orphan </footer> tags and restore semantic structure.
Changes:
- Add missing
</main>closing tags onindex.html,contact.html, andshop.html. - Introduce
<footer>…</footer>blocks after main content to ensure valid footer structure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
index.html |
Closes <main> and wraps footer content in a proper <footer> element. |
contact.html |
Closes <main> and adds a <footer> element (but footer contents differ from PR description). |
shop.html |
Closes <main> and wraps footer content in a proper <footer> element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
DavidKRK
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot apply changes based on the comments in this thread |
DavidKRK
added a commit
that referenced
this pull request
Apr 8, 2026
… index, contact, shop pages (#162) (#163) * Fix missing main/footer HTML structure in index, contact, shop pages Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905 * Move social icons into footer in contact.html Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
14 tasks
DavidKRK
added a commit
that referenced
this pull request
Apr 8, 2026
… index, contact, shop pages (#162) (#163) (#164) * Fix missing main/footer HTML structure in index, contact, shop pages Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905 * Move social icons into footer in contact.html Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<main>tag not closed (no</main>) and stray</footer>without opening<footer>in index.html, contact.html, shop.html</main>after player section, wrap footer content in<footer></main>after contact forms, wrap footer content (including social icons) in<footer></main>after shop content, wrap footer content in<footer><main>into<footer>in contact.html (reviewer feedback)