Fix invalid HTML structure (unclosed <main>, orphan </footer>) on…#163
Merged
Conversation
… index, contact, shop pages (#162) * Fix missing main/footer HTML structure in index, contact, shop pages Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> * Move social icons into footer in contact.html Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes invalid HTML structure on the public-facing pages by properly closing <main> and ensuring footer content is wrapped in a <footer> element (including moving social icons into the footer on contact.html).
Changes:
- Close previously unclosed
<main>elements onindex.html,contact.html, andshop.html. - Wrap footer content in a proper
<footer>element to eliminate orphan</footer>markup. - Relocate
contact.htmlsocial icon links into the footer section.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| index.html | Closes <main> and wraps the footer links/content in <footer> to restore valid page structure. |
| contact.html | Closes <main>, adds <footer>, and places social icons inside the footer. |
| shop.html | Closes <main> and introduces <footer> wrapper for the footer content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the semantic structure of the contact, index, and shop pages by introducing
and tags to wrap the content and social icons. A critical issue was identified in contact.html where a newly added within the footer is missing its corresponding closing tag, which would result in invalid HTML structure.
14 tasks
DavidKRK
added a commit
that referenced
this pull request
Apr 8, 2026
… index, contact, shop pages (#162) (#163) (#164) * Fix missing main/footer HTML structure in index, contact, shop pages Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905 * Move social icons into footer in contact.html Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… index, contact, shop pages (#162)
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/22a9b0b3-0b65-40f6-8d32-31b6fb1f1905
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/73fb46a3-65a6-497f-90fe-72daccefd627
name: Pull Request
about: Proposer un changement au projet
title: ''
labels: ''
assignees: ''
1. Quels sont les changements ?
Résumé des changements :
(Décrivez brièvement les modifications apportées.)
Tickets / Issues liés :
2. Pourquoi ces changements ?
Contexte métier :
(Expliquez la raison fonctionnelle ou business de ces changements.)
Justification technique :
(Expliquez les choix d'architecture ou d'implémentation retenus.)
3. Tests
Tests unitaires :
npm test/bundle exec rspec/ …)Tests manuels :
Performances & Sécurité :
4. Changements majeurs (Breaking Changes)
Cette PR introduit-elle des ruptures d'API ou de comportement ?
(Décrivez les ruptures et les impacts pour les consommateurs de l'API / les autres équipes.)
Instructions de migration :
(Si applicable, décrivez les étapes nécessaires pour migrer.)
5. Exigences de déploiement
Variables d'environnement :
NOM_VARvaleurNotes de déploiement supplémentaires :
(Toute information utile pour l'équipe de déploiement.)