fix: restrict owl background to index.html, isolate all non-home page… by DavidKRK · Pull Request #182 · DavidKRK/DavidKRK.github.io

DavidKRK · 2026-04-17T03:31:47Z

… classes (#181)

fix: restore background-image on index.html, isolate music-page class

Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/5d42fd6d-80f7-40cc-a2fe-311924b01ece

Update assets/css/style.css
fix: update all non-home pages to use page-specific body classes

Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/a7c79463-e3b3-4a62-94a6-3ba779a4d323

name: Pull Request
about: Proposer un changement au projet
title: ''
labels: ''
assignees: ''

1. Quels sont les changements ?

Résumé des changements :

(Décrivez brièvement les modifications apportées.)

Tickets / Issues liés :

Closes #
Ref #

2. Pourquoi ces changements ?

Contexte métier :

(Expliquez la raison fonctionnelle ou business de ces changements.)

Justification technique :

(Expliquez les choix d'architecture ou d'implémentation retenus.)

3. Tests

Tests unitaires :

Nouveaux tests ajoutés
Tests existants mis à jour
Tous les tests passent (npm test / bundle exec rspec / …)

Tests manuels :

Testé en local
Testé sur un environnement de staging / preview

Performances & Sécurité :

Impact sur les performances évalué
Aucune vulnérabilité introduite (dépendances, injection, XSS, …)

4. Changements majeurs (Breaking Changes)

Cette PR introduit-elle des ruptures d'API ou de comportement ?

Non
Oui — détails ci-dessous :

(Décrivez les ruptures et les impacts pour les consommateurs de l'API / les autres équipes.)

Instructions de migration :

(Si applicable, décrivez les étapes nécessaires pour migrer.)

5. Exigences de déploiement

Migrations de base de données à exécuter
Nouvelles variables d'environnement à configurer (listez-les ci-dessous)
Feature flags à activer / désactiver
Services tiers à configurer ou notifier
Documentation mise à jour

Variables d'environnement :

Variable	Description	Valeur par défaut
`NOM_VAR`	Description	`valeur`

Notes de déploiement supplémentaires :

(Toute information utile pour l'équipe de déploiement.)

… classes (#181) * fix: restore background-image on index.html, isolate music-page class Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/5d42fd6d-80f7-40cc-a2fe-311924b01ece Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> * Update assets/css/style.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: update all non-home pages to use page-specific body classes Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/a7c79463-e3b3-4a62-94a6-3ba779a4d323 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bolt-new-by-stackblitz · 2026-04-17T03:31:51Z

Run & review this pull request in StackBlitz Codeflow.

gemini-code-assist

Code Review

This pull request updates the body classes for several sub-pages (bio, contact, event, music, and shop) and adjusts the CSS for non-home pages to use flexbox. Feedback suggests consolidating duplicate flexbox properties into a common body selector and removing redundant background-image divs across the HTML files to clean up the DOM.

gemini-code-assist · 2026-04-17T03:33:44Z

+  display: flex;
+  flex-direction: column;


These flexbox properties are identical to those defined for body.home-page (lines 251-252). Since they are now applied to both home and non-home pages, it would be more maintainable to move them to a common body selector to avoid duplication and adhere to the DRY (Don't Repeat Yourself) principle.

gemini-code-assist · 2026-04-17T03:33:44Z

  <link rel="stylesheet" href="assets/css/style.css">
 </head>
-<body class="home-page">
+<body class="bio-page">


While updating the body class to bio-page, note that the <div class="background-image"></div> on line 40 appears to be redundant. The background is now managed via the body class in style.css, and this page does not import responsive.css where this div might have been used. Consider removing it to clean up the DOM.

gemini-code-assist · 2026-04-17T03:33:44Z

  </style>
 </head>
-<body class="home-page">
+<body class="music-page">


Similar to other sub-pages, the <div class="background-image"></div> on line 97 seems redundant now that the background is handled by the body class. Since responsive.css is not imported here, this div is likely unused and can be removed to avoid unnecessary elements in the DOM.

Copilot

Pull request overview

This PR fixes unintended inheritance of the home page owl background by ensuring only index.html uses the home-page body class, while all other pages use page-specific body classes and share a consistent non-home layout style.

Changes:

Updated non-home HTML pages to use page-specific <body class="…-page"> instead of home-page.
Extended the existing body:not(.home-page) CSS rule to apply display: flex and flex-direction: column across all non-home pages.
Kept body.home-page styling intact so the owl background remains exclusive to the home page.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
shop.html	Switches body class to `shop-page` to avoid inheriting home background styles.
music.html	Switches body class to `music-page` to avoid inheriting home background styles.
event.html	Switches body class to `event-page` to avoid inheriting home background styles.
contact.html	Switches body class to `contact-page` to avoid inheriting home background styles.
bio.html	Switches body class to `bio-page` to avoid inheriting home background styles.
assets/css/style.css	Ensures non-home pages share the same flex column body layout via `body:not(.home-page)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…index.html (#184) Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/28085f91-8e33-4a62-8391-35151e5a9bf3 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>

#185) * fix: apply owl background image to all pages, fix duplicate image on index.html Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/28085f91-8e33-4a62-8391-35151e5a9bf3 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> * fix: add background-color fallback to body for image load failures Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/400980e0-28f8-4279-bb21-d6468464f2dd Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

DavidKRK · 2026-04-17T04:33:40Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-04-17T04:33:44Z

@DavidKRK I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly.

You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

DavidKRK · 2026-04-17T04:37:25Z

create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

@copilot create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

Copilot · 2026-04-17T04:37:32Z

@DavidKRK I've opened a new pull request, #186, to work on those changes. Once the pull request is ready, I'll request review from you.

DavidKRK · 2026-04-17T04:40:30Z

@DavidKRK I've opened a new pull request, #186, to work on those changes. Once the pull request is ready, I'll request review from you.

@copilot What do I do now here ?

Copilot · 2026-04-17T04:40:34Z

@DavidKRK I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly.

You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

DavidKRK · 2026-04-17T04:44:05Z

@copilot resolve the merge conflicts in this pull request

DavidKRK requested a review from Copilot April 17, 2026 03:31

DavidKRK assigned DavidKRK, Copilot, Claude and Codex Apr 17, 2026

Copilot started reviewing on behalf of DavidKRK April 17, 2026 03:32 View session

gemini-code-assist Bot reviewed Apr 17, 2026

View reviewed changes

Copilot AI reviewed Apr 17, 2026

View reviewed changes

DavidKRK temporarily deployed to github-pages April 17, 2026 04:15 — with GitHub Actions Inactive

DavidKRK temporarily deployed to github-pages April 17, 2026 04:31 — with GitHub Actions Inactive

Copilot AI mentioned this pull request Apr 17, 2026

fix: apply owl background to all pages, remove redundant background-image div from index.html #186

Merged

DavidKRK closed this Apr 17, 2026

Conversation

DavidKRK commented Apr 17, 2026

1. Quels sont les changements ?

2. Pourquoi ces changements ?

3. Tests

4. Changements majeurs (Breaking Changes)

5. Exigences de déploiement

Uh oh!

bolt-new-by-stackblitz Bot commented Apr 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

DavidKRK commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026

Uh oh!

DavidKRK commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026

Uh oh!

DavidKRK commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026

Uh oh!

DavidKRK commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants