[WIP] Fix Buy Me A Coffee image aspect ratio on all pages#224
Merged
Conversation
|
|
6 tasks
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add descriptive alt text to Buy Me A Coffee images across all pages - Initialize default language (French) on all pages with language switchers - Remove deprecated frameborder attribute from event.html iframe - Add lang and dir attributes updates for accessibility and RTL support Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/a973c329-86c6-41f2-ab44-10dc099f5ea2 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
Comment on lines
+83
to
86
| <iframe title="Mixcloud player" width="100%" height="120" | ||
| style="border:0;" | ||
| src="https://player-widget.mixcloud.com/widget/iframe/?hide_cover=1&hide_artwork=1&autoplay=1&feed=%2FDavidKRK%2Fdavid-krk-life-good-techno-ep3%2F" | ||
| frameborder="0" | ||
| allow="autoplay; encrypted-media; fullscreen; idle-detection; speaker-selection; web-share"></iframe> |
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
Comment on lines
+174
to
177
| // Update document language and text direction for accessibility and RTL support | ||
| document.documentElement.lang = lang; | ||
| document.documentElement.dir = (lang === 'ar') ? 'rtl' : 'ltr'; | ||
| } |
| <a href="https://www.tiktok.com/@davidkrk" target="_blank" rel="noopener noreferrer" aria-label="TikTok" | ||
| class="social-icon text-2xl md:text-3xl text-white"><i class="fab fa-tiktok"></i></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> | ||
| <a href="https://www.buymeacoffee.com/davidkrk" target="_blank" rel="noopener noreferrer" aria-label="Buy Me A Coffee" class="social-icon text-2xl md:text-3xl"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="217" height="60" style="height: 1em; width: auto; vertical-align: middle;"></a> |
Comment on lines
+134
to
137
| // Update document language and text direction for accessibility and RTL support | ||
| document.documentElement.lang = lang; | ||
| document.documentElement.dir = (lang === 'ar') ? 'rtl' : 'ltr'; | ||
| } |
Comment on lines
+227
to
230
| // Update document language and text direction for accessibility and RTL support | ||
| document.documentElement.lang = lang; | ||
| document.documentElement.dir = (lang === 'ar') ? 'rtl' : 'ltr'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.