fix: complete WIP accessibility fixes — default language init, frameborder, RTL support#227
Merged
DavidKRK merged 2 commits intoMay 3, 2026
Conversation
|
|
6 tasks
…precated frameborder Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/25e7ed8a-287e-4178-b956-93c9a51a5fd8 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Buy Me A Coffee image aspect ratio and improve accessibility
fix: complete WIP accessibility fixes — default language init, frameborder, RTL support
May 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finishes a previously incomplete pass of language/accessibility cleanup on the localized static site pages. It mainly brings bio.html/assets/js/bio.js and contact.html in line with the site's language-switch initialization pattern and updates one deprecated iframe attribute.
Changes:
- Initialize French as the default visible language on
contact.htmland the bio page script. - Update
assets/js/bio.jsto sethtml[lang]anddirwhen switching languages for RTL/accessibility support. - Replace the deprecated
frameborderattribute on the bio page's Mixcloud iframe with CSS border styling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
contact.html |
Adds default switchLanguage('fr') initialization so one language panel is visible on load. |
bio.html |
Replaces deprecated iframe border markup with inline CSS styling. |
assets/js/bio.js |
Adds document lang/dir updates and initializes the bio page to French on load. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+21
| // Update document language and text direction for accessibility and RTL support | ||
| document.documentElement.lang = lang; | ||
| document.documentElement.dir = (lang === 'ar') ? 'rtl' : 'ltr'; |
| }); | ||
| }); | ||
|
|
||
| switchLanguage('fr'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commit (
1b82b7c) was merged as[WIP]— three accessibility/standards fixes were not applied tobio.html/bio.jsandcontact.html.Changes
contact.html: Add missingswitchLanguage('fr')call — page was rendering with no language content visible on loadbio.html: Remove deprecatedframeborder="0"from Mixcloud iframe →style="border:0;"(matchesevent.html)bio.js: AddswitchLanguage('fr')default init +document.documentElement.lang/.dirupdates for RTL accessibility