Skip to content

fix: increase tap target sizes to satisfy Lighthouse accessibility#258

Merged
DavidKRK merged 5 commits into
gh-pagesfrom
copilot/analyser-corriger-erreurs-lighthouse
Jun 2, 2026
Merged

fix: increase tap target sizes to satisfy Lighthouse accessibility#258
DavidKRK merged 5 commits into
gh-pagesfrom
copilot/analyser-corriger-erreurs-lighthouse

Conversation

@DavidKRK
Copy link
Copy Markdown
Owner

@DavidKRK DavidKRK commented Jun 2, 2026


name: Pull Request
about: Proposer un changement au projet
title: ''
labels: ''
assignees: ''


1. Quels sont les changements ?

Résumé des changements :

(Décrivez brièvement les modifications apportées.)

Tickets / Issues liés :

  • Closes #
  • Ref #

2. Pourquoi ces changements ?

Contexte métier :

(Expliquez la raison fonctionnelle ou business de ces changements.)

Justification technique :

(Expliquez les choix d'architecture ou d'implémentation retenus.)


3. Tests

Tests unitaires :

  • Nouveaux tests ajoutés
  • Tests existants mis à jour
  • Tous les tests passent (npm test / bundle exec rspec / …)

Tests manuels :

  • Testé en local
  • Testé sur un environnement de staging / preview

Performances & Sécurité :

  • Impact sur les performances évalué
  • Aucune vulnérabilité introduite (dépendances, injection, XSS, …)

4. Changements majeurs (Breaking Changes)

Cette PR introduit-elle des ruptures d'API ou de comportement ?

  • Non
  • Oui — détails ci-dessous :

(Décrivez les ruptures et les impacts pour les consommateurs de l'API / les autres équipes.)

Instructions de migration :

(Si applicable, décrivez les étapes nécessaires pour migrer.)


5. Exigences de déploiement

  • Migrations de base de données à exécuter
  • Nouvelles variables d'environnement à configurer (listez-les ci-dessous)
  • Feature flags à activer / désactiver
  • Services tiers à configurer ou notifier
  • Documentation mise à jour

Variables d'environnement :

Variable Description Valeur par défaut
NOM_VAR Description valeur

Notes de déploiement supplémentaires :

(Toute information utile pour l'équipe de déploiement.)

@DavidKRK DavidKRK self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 21:13
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts site CSS to enlarge interactive elements’ tap/click areas, aiming to address Lighthouse accessibility findings related to tap target sizing.

Changes:

  • Increased header navigation link tap targets via min-height + padding and flex alignment (.hero-header a).
  • Increased footer social icon tap targets via min-width/min-height + padding and centering (.social-icon).
  • Added/updated footer contact link and “support link” (Buy Me A Coffee) sizing rules to ensure minimum tap target dimensions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates assets/css/style.css to improve the tap target sizes of various links and icons, including header links, social icons, and footer contact links, by setting flex properties, padding, and minimum dimensions of 44px. The reviewer recommends increasing these minimum dimensions to 48px × 48px to fully comply with Google Lighthouse accessibility guidelines for mobile tap targets.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread assets/css/style.css
Comment thread assets/css/style.css Outdated
Comment thread assets/css/style.css Outdated
Comment thread assets/css/style.css Outdated
DavidKRK and others added 3 commits June 2, 2026 23:16
J'approuve la correction

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
J'approuve la correction

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
J'approuve la correction

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@DavidKRK
Copy link
Copy Markdown
Owner Author

DavidKRK commented Jun 2, 2026

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 2, 2026

@copilot resolve the merge conflicts in this pull request

Les conflits de fusion ont été résolus — commit 5553af4. Le conflit portait sur les valeurs de taille minimale dans assets/css/style.css : la branche gh-pages avait 44px (issu du PR #257 déjà fusionné), tandis que cette PR avait 48px. J'ai conservé les valeurs 48px de cette branche.

@DavidKRK DavidKRK merged commit aaf216d into gh-pages Jun 2, 2026
9 of 10 checks passed
@DavidKRK DavidKRK deleted the copilot/analyser-corriger-erreurs-lighthouse branch June 2, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants