Skip to content

Reduce false-positive “New Music Update” issues by diffing net-new music links #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidKRK merged 3 commits into from
Jun 3, 2026
Merged

Reduce false-positive “New Music Update” issues by diffing net-new music links #274

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1e6f3
Initial plan
Copilot Jun 3, 2026
c01fbe6
Reduce false positives in music update detection
Copilot Jun 3, 2026
2b6037d
Fix music-social new content detection
Copilot Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/music-social.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ jobs:
ADDED=$(echo "$DIFF" | grep "^+" | grep -v "^+++" | sed 's/^+//' | head -50)

# Extraire uniquement la section auto YouTube (source réelle des nouvelles entrées musicales)
MUSIC_LINK_PATTERN='https?://(www\.)?(youtube\.com|youtu\.be|soundcloud\.com|bandcamp\.com)'
YOUTUBE_VIDEO_PATTERN='https?://(www\.)?(youtube\.com/watch\?v=[^"[:space:]<]+|youtube\.com/shorts/[^"[:space:]<]+|youtu\.be/[^"[:space:]<]+)'
SOUNDCLOUD_PATTERN='https?://(www\.)?soundcloud\.com/[^"[:space:]<]+'
BANDCAMP_PATTERN='https?://([^"[:space:]<]+\.)?bandcamp\.com/[^"[:space:]<]+'
MUSIC_LINK_PATTERN="$YOUTUBE_VIDEO_PATTERN|$SOUNDCLOUD_PATTERN|$BANDCAMP_PATTERN"
NEW_MUSIC_BLOCK=$(git show "$TARGET_REF:music.html" | sed -n '/<!-- YOUTUBE-AUTO-START -->/,/<!-- YOUTUBE-AUTO-END -->/p')
if [ "$BASE_REF" = "$EMPTY_TREE" ]; then
OLD_MUSIC_BLOCK=""
Expand All @@ -74,8 +77,16 @@ jobs:
# Sauvegarder le diff dans un fichier temporaire pour l'issue
echo "$ADDED" > /tmp/music_changes.txt

# Détecter une vraie nouveauté musicale (nouveaux liens de contenu dans le bloc auto YouTube)
if echo "$MUSIC_BLOCK_ADDED" | grep -qiE "$MUSIC_LINK_PATTERN"; then
# Détecter une vraie nouveauté musicale (nouveaux liens de contenu par rapport à l'état précédent)
extract_music_links() {
echo "$1" | grep -oiE "$MUSIC_LINK_PATTERN" | LC_ALL=C sort -u
}
Comment on lines +81 to +83
if extract_music_links "$NEW_MUSIC_BLOCK" | grep -q .; then
NEW_LINKS_ONLY=$(LC_ALL=C comm -13 <(extract_music_links "$OLD_MUSIC_BLOCK") <(extract_music_links "$NEW_MUSIC_BLOCK") || true)
else
NEW_LINKS_ONLY=""
fi
if [ -n "$NEW_LINKS_ONLY" ]; then
echo "has_music_content=true" >> "$GITHUB_OUTPUT"
else
echo "has_music_content=false" >> "$GITHUB_OUTPUT"
Expand Down
Loading