Skip to content

Commit 2898547

Browse files
Added TzevaAdomListener to replace Consumer<Alert>
This simplifies both client code & the experience of the developers reading the library.
1 parent 689c994 commit 2898547

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package dte.tzevaadomapi.notifier;
2+
3+
import dte.tzevaadomapi.alert.Alert;
4+
5+
@FunctionalInterface
6+
public interface TzevaAdomListener
7+
{
8+
void onTzevaAdom(Alert alert);
9+
}

src/main/java/dte/tzevaadomapi/notifier/TzevaAdomNotifier.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class TzevaAdomNotifier implements Iterable<Alert>
2929
private final AlertSource alertSource;
3030
private final Duration requestDelay;
3131
private final Consumer<Exception> requestFailureHandler;
32-
private final Set<Consumer<Alert>> listeners = new HashSet<>();
32+
private final Set<TzevaAdomListener> listeners = new HashSet<>();
3333
private final Deque<Alert> history = new LinkedList<>();
3434

3535
private TzevaAdomNotifier(AlertSource alertSource, Duration requestDelay, Consumer<Exception> requestFailureHandler)
@@ -66,15 +66,15 @@ public CompletableFuture<Void> listen()
6666

6767
lastTzevaAdom = alert;
6868

69-
this.listeners.forEach(listener -> listener.accept(alert));
69+
this.listeners.forEach(listener -> listener.onTzevaAdom(alert));
7070
this.history.add(alert);
7171
}
7272
});
7373
}
7474

75-
public void addListener(Consumer<Alert> tzevaAdomListener)
75+
public void addListener(TzevaAdomListener listener)
7676
{
77-
this.listeners.add(tzevaAdomListener);
77+
this.listeners.add(listener);
7878
}
7979

8080
public Alert getLastAlert()
@@ -117,7 +117,7 @@ public static class Builder
117117
private AlertSource alertSource;
118118
private Duration requestDelay;
119119
private Consumer<Exception> requestFailureHandler = (exception) -> {};
120-
private Set<Consumer<Alert>> listeners = new HashSet<>();
120+
private Set<TzevaAdomListener> listeners = new HashSet<>();
121121

122122
public Builder requestFrom(AlertSource alertSource)
123123
{
@@ -137,7 +137,7 @@ public Builder onFailedRequest(Consumer<Exception> handler)
137137
return this;
138138
}
139139

140-
public Builder onTzevaAdom(Consumer<Alert> listener)
140+
public Builder onTzevaAdom(TzevaAdomListener listener)
141141
{
142142
this.listeners.add(listener);
143143
return this;

0 commit comments

Comments
 (0)