Skip to content

Commit d471065

Browse files
committed
fixed bug with label of Arrow2DSeries/Arrow3DSeries
1 parent c432eac commit d471065

4 files changed

Lines changed: 30 additions & 3 deletions

File tree

doc/source/changelog.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22
Changelog
33
==========
44

5+
v4.0.3
6+
======
7+
8+
* Fixed bug with label of ``tick_formatter_multiples_of``.
9+
* Fixed bug with label of ``Arrow2DSeries/Arrow3DSeries``.
10+
11+
512
v4.0.2
613
======
714

spb/series/vectors.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,13 @@ def get_label(self, use_latex=False, wrapper="$%s$"):
626626
"""
627627
if use_latex is False:
628628
return self._label_str
629-
return self._get_wrapped_label(self._label_latex, wrapper)
629+
630+
# if the default label is shown, then it'll start with \left(...
631+
label = self._label_latex
632+
if label[0] == "\\":
633+
return self._get_wrapped_label(self._label_latex, wrapper)
634+
# if the user provided the label
635+
return label
630636

631637
def get_data(self):
632638
"""

tests/backends/test_matplotlib.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2079,7 +2079,7 @@ def test_arrow_2d():
20792079
assert isinstance(ax, Axes)
20802080
assert len(ax.patches) == 1
20812081
assert len(ax.get_legend().legend_handles) == 1
2082-
assert ax.get_legend().legend_handles[0].get_label() == "$test$"
2082+
assert ax.get_legend().legend_handles[0].get_label() == "test"
20832083
assert ax.get_legend().legend_handles[0].get_color() == "r"
20842084
p.backend.update_interactive({a: 4, b: 5})
20852085
p.backend.close()
@@ -2145,7 +2145,7 @@ def test_arrow_3d():
21452145
assert isinstance(ax, mpl_toolkits.mplot3d.axes3d.Axes3D)
21462146
assert len(ax.patches) == 1
21472147
assert len(ax.get_legend().legend_handles) == 1
2148-
assert ax.get_legend().legend_handles[0].get_label() == "$test$"
2148+
assert ax.get_legend().legend_handles[0].get_label() == "test"
21492149
assert ax.get_legend().legend_handles[0].get_color() == "r"
21502150
# only way to test if it renders what it's supposed to
21512151
assert np.allclose(ax.patches[0]._xyz, [1, 2, 3])

tests/test_series.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2588,6 +2588,20 @@ def test_series_labels():
25882588
assert s2.get_label(False) == "test"
25892589
assert s2.get_label(True) == "test"
25902590

2591+
s1 = Arrow2DSeries((0, 1), (2, 3))
2592+
assert s1.get_label(False) == "(0.0, 1.0) -> (2.0, 4.0)"
2593+
assert s1.get_label(True) == r"$\left(0.0, 1.0\right) \rightarrow \left(2.0, 4.0\right)$"
2594+
s2 = Arrow2DSeries((0, 1), (2, 3), "test")
2595+
assert s2.get_label(False) == "test"
2596+
assert s2.get_label(True) == "test"
2597+
2598+
s1 = Arrow3DSeries((0, 1, 2), (3, 4, 5))
2599+
assert s1.get_label(False) == "(0.0, 1.0, 2.0) -> (3.0, 5.0, 7.0)"
2600+
assert s1.get_label(True) == r"$\left(0.0, 1.0, 2.0\right) \rightarrow \left(3.0, 5.0, 7.0\right)$"
2601+
s2 = Arrow3DSeries((0, 1, 2), (3, 4, 5), "test")
2602+
assert s2.get_label(False) == "test"
2603+
assert s2.get_label(True) == "test"
2604+
25912605

25922606
@pytest.mark.parametrize(
25932607
"use_cm", [None, True, False]

0 commit comments

Comments
 (0)