Skip to content

Commit 119d329

Browse files
author
Zhe Yu
committed
fix broken tests (for github actions)
1 parent b6e9aad commit 119d329

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/vectorcode/subcommands/query/reranker/base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,7 @@ def create(cls, configs: Config, **kwargs: Any):
3838
raise
3939

4040
@abstractmethod
41-
def rerank(self, results: QueryResult, query_chunks: list[str]) -> list[str]:
41+
def rerank(
42+
self, results: QueryResult, query_chunks: list[str]
43+
) -> list[str]: # pragma: nocover
4244
raise NotImplementedError

tests/subcommands/query/test_reranker.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,13 +262,11 @@ def test_get_reranker():
262262
), "configs.reranker_params should fallback to default params."
263263

264264

265-
def test_supported_rerankers_initialization():
265+
def test_supported_rerankers_initialization(config, naive_reranker_conf):
266266
"""Test that __supported_rerankers contains the expected default rerankers"""
267267

268-
assert isinstance(
269-
get_reranker(Config(reranker="CrossEncoderReranker")), CrossEncoderReranker
270-
)
271-
assert isinstance(get_reranker(Config(reranker="NaiveReranker")), NaiveReranker)
268+
assert isinstance(get_reranker(config), CrossEncoderReranker)
269+
assert isinstance(get_reranker(naive_reranker_conf), NaiveReranker)
272270
assert len(get_available_rerankers()) == 2
273271

274272

0 commit comments

Comments
 (0)