Skip to content

Commit 27f96ef

Browse files
Zhe YuDavidyz
authored andcommitted
typo.
1 parent 55e0745 commit 27f96ef

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/vectorcode/subcommands/query/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
logger = logging.getLogger(name=__name__)
3333

3434

35-
def conver_query_results(
35+
def convert_query_results(
3636
chroma_result: QueryResult, queries: list[str]
3737
) -> list[vectorcode_types.QueryResult]:
3838
"""Convert chromadb query result to in-house query results"""
@@ -119,7 +119,7 @@ async def get_query_result_files(
119119

120120
reranker = get_reranker(configs)
121121
return await reranker.rerank(
122-
conver_query_results(chroma_query_results, configs.query)
122+
convert_query_results(chroma_query_results, configs.query)
123123
)
124124

125125

tests/subcommands/query/test_query.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from vectorcode.cli_utils import CliAction, Config, QueryInclude
1010
from vectorcode.subcommands.query import (
1111
build_query_results,
12-
conver_query_results,
12+
convert_query_results,
1313
get_query_result_files,
1414
query,
1515
)
@@ -66,6 +66,7 @@ def mock_config():
6666
@pytest.mark.asyncio
6767
async def test_get_query_result_files(mock_collection, mock_config):
6868
mock_embedding_function = MagicMock()
69+
mock_config.embedding_dims = 10
6970
with (
7071
patch("vectorcode.subcommands.query.get_reranker") as mock_get_reranker,
7172
patch(
@@ -99,11 +100,14 @@ async def test_get_query_result_files(mock_collection, mock_config):
99100
# Check reranker was used correctly
100101
mock_get_reranker.assert_called_once_with(mock_config)
101102
mock_reranker_instance.rerank.assert_called_once_with(
102-
conver_query_results(mock_collection.query.return_value, mock_config.query)
103+
convert_query_results(mock_collection.query.return_value, mock_config.query)
103104
)
104105

105106
# Check the result
106107
assert result == ["file1.py", "file2.py", "file3.py"]
108+
assert all(
109+
len(i) == 10 for i in mock_collection.query.kwargs["query_embeddings"]
110+
)
107111

108112

109113
@pytest.mark.asyncio

0 commit comments

Comments
 (0)