improve coverage

Author: Zhe Yu

src/vectorcode/chunking.py

@@ -50,10 +50,6 @@ def export_dict(self):
                     "end": {"row": self.end.row, "column": self.end.column},
                 }
             )
-        if self.path is not None:
-            d["path"] = self.path
-        if self.id:
-            d["chunk_id"] = self.id
         return d
 
 

src/vectorcode/subcommands/query/__init__.py

@@ -140,7 +140,7 @@ def make_output_path(path: str, absolute: bool) -> str:
         else:
             rel_path = os.path.relpath(path, configs.project_root)
             if isinstance(rel_path, bytes):  # pragma: nocover
-                # for some reasons some python versions report that `os.path.relpath` returns a string.
+                # for some reasons, some python versions report that `os.path.relpath` returns a string.
                 rel_path = rel_path.decode()
             return rel_path
 

tests/subcommands/query/test_query.py

@@ -133,50 +133,56 @@ async def test_get_query_result_files_include_chunk(mock_collection, mock_config
 @pytest.mark.asyncio
 async def test_build_query_results_chunk_mode_success(mock_collection, mock_config):
     """Test build_query_results in chunk mode successfully retrieves chunk details."""
-    mock_config.include = [QueryInclude.chunk, QueryInclude.path]
-    mock_config.project_root = "/test/project"
-    mock_config.use_absolute_path = False
-    mock_config.query = ["dummy_query"]
-    identifier = "chunk_id"
-    file_path = "/test/project/subdir/file1.py"
-    relative_path = "subdir/file1.py"
-    start_line = 5
-    end_line = 10
-
-    full_file_content_lines = [f"line {i}\n" for i in range(15)]
-
-    expected_chunk_content = "".join(full_file_content_lines[start_line : end_line + 1])
-
-    mock_get_result = QueryResult(
-        ids=[[identifier]],
-        documents=[[expected_chunk_content]],
-        metadatas=[[{"path": file_path, "start": start_line, "end": end_line}]],
-        distances=[[0.2]],
-    )
-    mock_collection.query = AsyncMock(return_value=mock_get_result)
-    with (
-        patch(
-            "vectorcode.subcommands.query.get_query_result_files",
-            return_value=await get_query_result_files(mock_collection, mock_config),
-        ),
-        patch("os.path.isfile", return_value=False),
-        patch("os.path.relpath", return_value=relative_path) as mock_relpath,
-    ):
-        results = await build_query_results(mock_collection, mock_config)
-
-        mock_relpath.assert_called_once_with(file_path, str(mock_config.project_root))
-
-        assert len(results) == 1
-
-        expected_full_result = {
-            "path": relative_path,
-            "chunk": expected_chunk_content,
-            "start_line": start_line,
-            "end_line": end_line,
-            "chunk_id": identifier,
-        }
+    for request_abs_path in (True, False):
+        mock_config.include = [QueryInclude.chunk, QueryInclude.path]
+        mock_config.project_root = "/test/project"
+        mock_config.use_absolute_path = request_abs_path
+        mock_config.query = ["dummy_query"]
+        identifier = "chunk_id"
+        file_path = "/test/project/subdir/file1.py"
+        relative_path = "subdir/file1.py"
+        start_line = 5
+        end_line = 10
+
+        full_file_content_lines = [f"line {i}\n" for i in range(15)]
+
+        expected_chunk_content = "".join(
+            full_file_content_lines[start_line : end_line + 1]
+        )
 
-        assert results[0] == expected_full_result
+        mock_get_result = QueryResult(
+            ids=[[identifier]],
+            documents=[[expected_chunk_content]],
+            metadatas=[[{"path": file_path, "start": start_line, "end": end_line}]],
+            distances=[[0.2]],
+        )
+        mock_collection.query = AsyncMock(return_value=mock_get_result)
+        with (
+            patch(
+                "vectorcode.subcommands.query.get_query_result_files",
+                return_value=await get_query_result_files(mock_collection, mock_config),
+            ),
+            patch("os.path.isfile", return_value=False),
+            patch("os.path.relpath", return_value=relative_path) as mock_relpath,
+        ):
+            results = await build_query_results(mock_collection, mock_config)
+
+            if not request_abs_path:
+                mock_relpath.assert_called_once_with(
+                    file_path, str(mock_config.project_root)
+                )
+
+            assert len(results) == 1
+
+            expected_full_result = {
+                "path": file_path if request_abs_path else relative_path,
+                "chunk": expected_chunk_content,
+                "start_line": start_line,
+                "end_line": end_line,
+                "chunk_id": identifier,
+            }
+
+            assert results[0] == expected_full_result
 
 
 @pytest.mark.asyncio