fix chroma startup subprocess

Author: Zhe Yu

src/vectorcode/common.py

@@ -87,19 +87,20 @@ async def start_server(configs: Config):
         f"Starting bundled ChromaDB server at {configs.host}:{configs.port}."
     )
     env.update({"ANONYMIZED_TELEMETRY": "False"})
+    exe = os.path.join(sys.prefix, "bin", "chroma")
+    if not os.path.isfile(exe):
+        exe = os.path.join(sys.prefix, "Scripts", "chroma")
     process = await asyncio.create_subprocess_exec(
-        sys.executable,
-        "-m",
-        "chromadb.cli.cli",
+        exe,
         "run",
         "--host",
         "localhost",
         "--port",
         str(configs.port),
         "--path",
         db_path,
-        "--log-path",
-        os.path.join(str(configs.db_log_path), "chroma.log"),
+        # "--log-path",
+        # os.path.join(str(configs.db_log_path), "chroma.log"),
         stdout=subprocess.DEVNULL,
         stderr=sys.stderr,
         env=env,

tests/test_common.py

@@ -428,21 +428,20 @@ def _new_isdir(path):
             MockCreateProcess.assert_called_once()
             args, kwargs = MockCreateProcess.call_args
             expected_args = [
-                sys.executable,
-                "-m",
-                "chromadb.cli.cli",
                 "run",
                 "--host",
                 "localhost",
                 "--port",
                 str(12345),  # Check the mocked port
                 "--path",
                 temp_dir,
-                "--log-path",
-                os.path.join(str(config.db_log_path), "chroma.log"),
+                # "--log-path",
+                # os.path.join(str(config.db_log_path), "chroma.log"),
             ]
-            assert args[0] == sys.executable
-            assert tuple(args[1:]) == tuple(expected_args[1:])
+            assert os.path.isfile(args[0]) and "chroma" in args[0], (
+                f"{args[0]} should be the path to the `chroma` executable."
+            )
+            assert tuple(args[1:]) == tuple(expected_args)
             assert kwargs["stdout"] == subprocess.DEVNULL
             assert kwargs["stderr"] == sys.stderr
             assert "ANONYMIZED_TELEMETRY" in kwargs["env"]