Skip to content

Commit ed4b3bd

Browse files
author
Zhe Yu
committed
fix broken tests (for github actions)
1 parent b6e9aad commit ed4b3bd

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/vectorcode/subcommands/query/reranker/base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,7 @@ def create(cls, configs: Config, **kwargs: Any):
3838
raise
3939

4040
@abstractmethod
41-
def rerank(self, results: QueryResult, query_chunks: list[str]) -> list[str]:
41+
def rerank(
42+
self, results: QueryResult, query_chunks: list[str]
43+
) -> list[str]: # pragma: nocover
4244
raise NotImplementedError

tests/subcommands/query/test_reranker.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,7 @@ def query_chunks():
5555
return ["query chunk 1", "query chunk 2"]
5656

5757

58-
# The RerankerBase isn't actually preventing instantiation,
59-
# but it will raise NotImplementedError when rerank is called
6058
def test_reranker_base_method_is_abstract(config):
61-
"""Test that RerankerBase.rerank raises NotImplementedError"""
6259
with pytest.raises((NotImplementedError, TypeError)):
6360
RerankerBase(config)
6461

@@ -262,13 +259,11 @@ def test_get_reranker():
262259
), "configs.reranker_params should fallback to default params."
263260

264261

265-
def test_supported_rerankers_initialization():
262+
def test_supported_rerankers_initialization(config, naive_reranker_conf):
266263
"""Test that __supported_rerankers contains the expected default rerankers"""
267264

268-
assert isinstance(
269-
get_reranker(Config(reranker="CrossEncoderReranker")), CrossEncoderReranker
270-
)
271-
assert isinstance(get_reranker(Config(reranker="NaiveReranker")), NaiveReranker)
265+
assert isinstance(get_reranker(config), CrossEncoderReranker)
266+
assert isinstance(get_reranker(naive_reranker_conf), NaiveReranker)
272267
assert len(get_available_rerankers()) == 2
273268

274269

0 commit comments

Comments
 (0)