Skip to content

Commit 1d1fc01

Browse files
author
yangjianbo
committed
fix(lint): resolve data management staticcheck warnings
1 parent bb664d9 commit 1d1fc01

2 files changed

Lines changed: 26 additions & 8 deletions

File tree

backend/internal/handler/admin/data_management_handler.go

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package admin
22

33
import (
4+
"context"
45
"strconv"
56
"strings"
67

@@ -13,13 +14,34 @@ import (
1314
)
1415

1516
type DataManagementHandler struct {
16-
dataManagementService *service.DataManagementService
17+
dataManagementService dataManagementService
1718
}
1819

1920
func NewDataManagementHandler(dataManagementService *service.DataManagementService) *DataManagementHandler {
2021
return &DataManagementHandler{dataManagementService: dataManagementService}
2122
}
2223

24+
type dataManagementService interface {
25+
GetConfig(ctx context.Context) (service.DataManagementConfig, error)
26+
UpdateConfig(ctx context.Context, cfg service.DataManagementConfig) (service.DataManagementConfig, error)
27+
ValidateS3(ctx context.Context, cfg service.DataManagementS3Config) (service.DataManagementTestS3Result, error)
28+
CreateBackupJob(ctx context.Context, input service.DataManagementCreateBackupJobInput) (service.DataManagementBackupJob, error)
29+
ListSourceProfiles(ctx context.Context, sourceType string) ([]service.DataManagementSourceProfile, error)
30+
CreateSourceProfile(ctx context.Context, input service.DataManagementCreateSourceProfileInput) (service.DataManagementSourceProfile, error)
31+
UpdateSourceProfile(ctx context.Context, input service.DataManagementUpdateSourceProfileInput) (service.DataManagementSourceProfile, error)
32+
DeleteSourceProfile(ctx context.Context, sourceType, profileID string) error
33+
SetActiveSourceProfile(ctx context.Context, sourceType, profileID string) (service.DataManagementSourceProfile, error)
34+
ListS3Profiles(ctx context.Context) ([]service.DataManagementS3Profile, error)
35+
CreateS3Profile(ctx context.Context, input service.DataManagementCreateS3ProfileInput) (service.DataManagementS3Profile, error)
36+
UpdateS3Profile(ctx context.Context, input service.DataManagementUpdateS3ProfileInput) (service.DataManagementS3Profile, error)
37+
DeleteS3Profile(ctx context.Context, profileID string) error
38+
SetActiveS3Profile(ctx context.Context, profileID string) (service.DataManagementS3Profile, error)
39+
ListBackupJobs(ctx context.Context, input service.DataManagementListBackupJobsInput) (service.DataManagementListBackupJobsResult, error)
40+
GetBackupJob(ctx context.Context, jobID string) (service.DataManagementBackupJob, error)
41+
EnsureAgentEnabled(ctx context.Context) error
42+
GetAgentHealth(ctx context.Context) service.DataManagementAgentHealth
43+
}
44+
2345
type TestS3ConnectionRequest struct {
2446
Endpoint string `json:"endpoint"`
2547
Region string `json:"region" binding:"required"`

backend/internal/service/data_management_service.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,25 +55,21 @@ type DataManagementAgentInfo struct {
5555
}
5656

5757
type DataManagementService struct {
58-
socketPath string
59-
dialTimeout time.Duration
58+
socketPath string
6059
}
6160

6261
func NewDataManagementService() *DataManagementService {
6362
return NewDataManagementServiceWithOptions(DefaultDataManagementAgentSocketPath, 500*time.Millisecond)
6463
}
6564

6665
func NewDataManagementServiceWithOptions(socketPath string, dialTimeout time.Duration) *DataManagementService {
66+
_ = dialTimeout
6767
path := strings.TrimSpace(socketPath)
6868
if path == "" {
6969
path = DefaultDataManagementAgentSocketPath
7070
}
71-
if dialTimeout <= 0 {
72-
dialTimeout = 500 * time.Millisecond
73-
}
7471
return &DataManagementService{
75-
socketPath: path,
76-
dialTimeout: dialTimeout,
72+
socketPath: path,
7773
}
7874
}
7975

0 commit comments

Comments
 (0)