Merge branch 'main' of http://127.0.0.1:39015/git/DeDuckProject/git-glimpse into claude/fix-mobile-gif-preview-DP7gy

Author: claude

.github/workflows/demo.yml

@@ -1,6 +1,13 @@
 # GitGlimpse E2E Demo Workflow
 # Runs the action against a local example app on every PR.
 # Safe: no untrusted user input (PR titles/bodies) is used in run: commands.
+#
+# ⚠️  IMPORTANT — changes to this file only take effect after merging to main.
+#
+# GitHub always reads issue_comment workflows from the default branch (main),
+# so edits to this file on a feature branch are silently ignored when /glimpse
+# is triggered. To test a workflow change: merge to main first, then re-run.
+# (Action/core code changes are fine on branches — they are rebuilt from source.)
 name: GitGlimpse Demo
 
 on:
@@ -21,20 +28,14 @@ jobs:
     permissions:
       pull-requests: write
       contents: write
+      issues: write
 
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           ref: ${{ github.event_name == 'issue_comment' && format('refs/pull/{0}/head', github.event.issue.number) || '' }}
 
-      # On issue_comment we check out the PR head (for app code), but need
-      # the action from main (which has trigger support). The bundled dist
-      # includes all core logic, so restoring just packages/action/ suffices.
-      - name: Use latest action code from main
-        if: github.event_name == 'issue_comment'
-        run: git checkout origin/main -- packages/action/
-
       - uses: pnpm/action-setup@v4
 
       - uses: actions/setup-node@v4
@@ -45,6 +46,12 @@ jobs:
       - name: Install dependencies
         run: pnpm install
 
+      # Always build from source so the action dist matches the checked-out code.
+      # This ensures /glimpse on a PR branch uses that branch's action/core code,
+      # not whatever was last committed to dist or published to main.
+      - name: Build action from source
+        run: pnpm build
+
       # Check whether the pipeline should run before installing heavy dependencies.
       # Subsequent steps are gated on this output to skip ffmpeg/Playwright when
       # the trigger config (on-demand, smart, etc.) decides to skip the run.
@@ -93,3 +100,24 @@ jobs:
         env:
           ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: React with hooray on success
+        if: >-
+          github.event_name == 'issue_comment' &&
+          steps.check.outputs.should-run == 'true' &&
+          success()
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh api repos/$GITHUB_REPOSITORY/issues/comments/${{ github.event.comment.id }}/reactions \
+            --method POST --field content=hooray || true
+
+      - name: React with confused on failure
+        if: >-
+          github.event_name == 'issue_comment' &&
+          failure()
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh api repos/$GITHUB_REPOSITORY/issues/comments/${{ github.event.comment.id }}/reactions \
+            --method POST --field content=confused || true

.github/workflows/glimpse-ack.yml

@@ -0,0 +1,40 @@
+# GitGlimpse Acknowledge Workflow
+#
+# OPTIONAL — this workflow is not required for git-glimpse to work.
+# The demo pipeline runs and posts its comment regardless of whether
+# this file exists.
+#
+# What it does: reacts with 👀 on the /glimpse comment as soon as a
+# runner is available (~15–30s), giving the commenter immediate visual
+# confirmation that their request was received — before the heavy
+# pipeline steps begin.
+#
+# Why it's a separate file: keeping it separate from the main workflow
+# means it never shows up as a "skipped" check on pull_request events.
+# If it were in the same file as the demo job, GitHub would show an
+# "ack (skipped)" entry in the PR checks on every push — noise for
+# non-developer reviewers.
+#
+# ⚠️  Changes only take effect after merging to main (GitHub reads
+#     issue_comment workflows from the default branch).
+name: GitGlimpse Acknowledge
+
+on:
+  issue_comment:
+    types: [created]
+
+jobs:
+  ack:
+    if: >-
+      github.event.issue.pull_request != null &&
+      contains(github.event.comment.body, '/glimpse')
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - name: React with eyes
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh api repos/$GITHUB_REPOSITORY/issues/comments/${{ github.event.comment.id }}/reactions \
+            --method POST --field content=eyes || true

CLAUDE.md

@@ -49,6 +49,22 @@ pnpm test --watch   # watch mode
 
 Integration tests require a running app. See `tests/integration/`.
 
+## External-First Design Principle
+
+git-glimpse is used as a GitHub Action (and in future possibly a GitHub App) by *other* repos —
+not just this one. Every change we make must account for the experience of those consumers.
+
+**Rules of thumb:**
+- **Seamless by default**: aim for zero-config or minimal-config integration that just works.
+- **Control when needed**: if seamless isn't achievable (e.g. workflow-level changes), provide
+  clear documentation, sample workflow snippets, and ideally a wrapper action.
+- **No silent breakage**: changes to action inputs/outputs, config schema, or workflow events must
+  be backwards-compatible or clearly versioned.
+- **Test from the outside**: validate features as if you were a consumer repo, not just via this
+  repo's internal `demo.yml`.
+- **Discuss trade-offs**: if a feature requires consumers to make non-trivial changes (new secrets,
+  new workflow jobs, new permissions), flag it in the PR for a deliberate decision.
+
 ## Branching Convention
 
 - Features: `feat/<name>`