Commit 8fa7bfe
committed
feat: move ack job to separate workflow to eliminate skipped-check noise
The `ack` job was defined in `demo.yml`, which triggers on both
`pull_request` and `issue_comment`. On every PR push, GitHub would mark
it as "Skipped" — visual noise in the checks list, especially for
non-developer reviewers.
Fix: move `ack` to `glimpse-ack.yml`, which only listens to
`issue_comment`. It never triggers on `pull_request` events, so it
never appears as a skipped check on PRs.
The new file is clearly documented as OPTIONAL — the demo pipeline
works without it. It only adds the immediate 👀 reaction UX.
Also adds `issues: write` to the `demo` job so the hooray/confused
completion reactions via `gh api` work reliably.
https://claude.ai/code/session_01JHYRHYBPULqbjvS5eayG2e1 parent 132ac46 commit 8fa7bfe
2 files changed
Lines changed: 41 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 20 | | |
39 | 21 | | |
40 | 22 | | |
| |||
46 | 28 | | |
47 | 29 | | |
48 | 30 | | |
| 31 | + | |
49 | 32 | | |
50 | 33 | | |
51 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
0 commit comments