Skip to content

Commit 8fa7bfe

Browse files
committed
feat: move ack job to separate workflow to eliminate skipped-check noise
The `ack` job was defined in `demo.yml`, which triggers on both `pull_request` and `issue_comment`. On every PR push, GitHub would mark it as "Skipped" — visual noise in the checks list, especially for non-developer reviewers. Fix: move `ack` to `glimpse-ack.yml`, which only listens to `issue_comment`. It never triggers on `pull_request` events, so it never appears as a skipped check on PRs. The new file is clearly documented as OPTIONAL — the demo pipeline works without it. It only adds the immediate 👀 reaction UX. Also adds `issues: write` to the `demo` job so the hooray/confused completion reactions via `gh api` work reliably. https://claude.ai/code/session_01JHYRHYBPULqbjvS5eayG2e
1 parent 132ac46 commit 8fa7bfe

2 files changed

Lines changed: 41 additions & 18 deletions

File tree

.github/workflows/demo.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,6 @@ on:
1717
types: [created]
1818

1919
jobs:
20-
# Lightweight job: reacts with 👀 immediately — no checkout or install needed.
21-
# Runs in parallel with the demo job so the acknowledgment appears as fast as possible.
22-
ack:
23-
if: >-
24-
github.event_name == 'issue_comment' &&
25-
github.event.issue.pull_request != null &&
26-
contains(github.event.comment.body, '/glimpse')
27-
runs-on: ubuntu-latest
28-
permissions:
29-
issues: write
30-
steps:
31-
- name: React with eyes
32-
env:
33-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
34-
run: |
35-
gh api repos/$GITHUB_REPOSITORY/issues/comments/${{ github.event.comment.id }}/reactions \
36-
--method POST --field content=eyes || true
37-
3820
demo:
3921
runs-on: ubuntu-latest
4022
# Run on PR events, or on issue_comment only if it's a PR comment containing /glimpse
@@ -46,6 +28,7 @@ jobs:
4628
permissions:
4729
pull-requests: write
4830
contents: write
31+
issues: write
4932

5033
steps:
5134
- uses: actions/checkout@v4

.github/workflows/glimpse-ack.yml

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# GitGlimpse Acknowledge Workflow
2+
#
3+
# OPTIONAL — this workflow is not required for git-glimpse to work.
4+
# The demo pipeline runs and posts its comment regardless of whether
5+
# this file exists.
6+
#
7+
# What it does: reacts with 👀 on the /glimpse comment as soon as a
8+
# runner is available (~15–30s), giving the commenter immediate visual
9+
# confirmation that their request was received — before the heavy
10+
# pipeline steps begin.
11+
#
12+
# Why it's a separate file: keeping it separate from the main workflow
13+
# means it never shows up as a "skipped" check on pull_request events.
14+
# If it were in the same file as the demo job, GitHub would show an
15+
# "ack (skipped)" entry in the PR checks on every push — noise for
16+
# non-developer reviewers.
17+
#
18+
# ⚠️ Changes only take effect after merging to main (GitHub reads
19+
# issue_comment workflows from the default branch).
20+
name: GitGlimpse Acknowledge
21+
22+
on:
23+
issue_comment:
24+
types: [created]
25+
26+
jobs:
27+
ack:
28+
if: >-
29+
github.event.issue.pull_request != null &&
30+
contains(github.event.comment.body, '/glimpse')
31+
runs-on: ubuntu-latest
32+
permissions:
33+
issues: write
34+
steps:
35+
- name: React with eyes
36+
env:
37+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
38+
run: |
39+
gh api repos/$GITHUB_REPOSITORY/issues/comments/${{ github.event.comment.id }}/reactions \
40+
--method POST --field content=eyes || true

0 commit comments

Comments
 (0)