Skip to content

Commit 9d4bc7b

Browse files
committed
fix: use explicit null check for pull_request in workflow if condition
GitHub Actions expression evaluator doesn't reliably coerce objects to boolean in compound && expressions. Changed from truthy check to explicit != null comparison. https://claude.ai/code/session_01F7qRXukhynYjUukzhaBzSK
1 parent 1830132 commit 9d4bc7b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/demo.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
if: >-
1717
github.event_name == 'pull_request' ||
1818
(github.event_name == 'issue_comment' &&
19-
github.event.issue.pull_request &&
19+
github.event.issue.pull_request != null &&
2020
contains(github.event.comment.body, '/glimpse'))
2121
permissions:
2222
pull-requests: write

0 commit comments

Comments
 (0)