Merge pull request #22 from DeDuckProject/fix/glimpse-uses-pr-branch-code

fix: build action from source so /glimpse uses PR branch code

Author: DeDuckProject

.github/workflows/demo.yml

@@ -1,6 +1,13 @@
 # GitGlimpse E2E Demo Workflow
 # Runs the action against a local example app on every PR.
 # Safe: no untrusted user input (PR titles/bodies) is used in run: commands.
+#
+# ⚠️  IMPORTANT — changes to this file only take effect after merging to main.
+#
+# GitHub always reads issue_comment workflows from the default branch (main),
+# so edits to this file on a feature branch are silently ignored when /glimpse
+# is triggered. To test a workflow change: merge to main first, then re-run.
+# (Action/core code changes are fine on branches — they are rebuilt from source.)
 name: GitGlimpse Demo
 
 on:
@@ -28,13 +35,6 @@ jobs:
           fetch-depth: 0
           ref: ${{ github.event_name == 'issue_comment' && format('refs/pull/{0}/head', github.event.issue.number) || '' }}
 
-      # On issue_comment we check out the PR head (for app code), but need
-      # the action from main (which has trigger support). The bundled dist
-      # includes all core logic, so restoring just packages/action/ suffices.
-      - name: Use latest action code from main
-        if: github.event_name == 'issue_comment'
-        run: git checkout origin/main -- packages/action/
-
       - uses: pnpm/action-setup@v4
 
       - uses: actions/setup-node@v4
@@ -45,6 +45,12 @@ jobs:
       - name: Install dependencies
         run: pnpm install
 
+      # Always build from source so the action dist matches the checked-out code.
+      # This ensures /glimpse on a PR branch uses that branch's action/core code,
+      # not whatever was last committed to dist or published to main.
+      - name: Build action from source
+        run: pnpm build
+
       # Check whether the pipeline should run before installing heavy dependencies.
       # Subsequent steps are gated on this output to skip ffmpeg/Playwright when
       # the trigger config (on-demand, smart, etc.) decides to skip the run.
@@ -93,12 +99,3 @@ jobs:
         env:
           ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GG_DEBUG_TRACE: '1'
-
-      - name: Upload Playwright trace
-        if: always() && steps.check.outputs.should-run == 'true'
-        uses: actions/upload-artifact@v4
-        with:
-          name: playwright-trace
-          path: ./recordings/trace.zip
-          if-no-files-found: ignore

packages/action/dist/index.js

@@ -41907,10 +41907,6 @@ async function runScriptAndRecord(options) {
   const startTime = Date.now();
   try {
     const context2 = await createContext(browser, recording, outputDir);
-    const enableTrace = process.env["GG_DEBUG_TRACE"] === "1";
-    if (enableTrace) {
-      await context2.tracing.start({ screenshots: true, snapshots: true, sources: false });
-    }
     const page = await context2.newPage();
     if (recording.showMouseClicks !== false) {
       page.on("load", () => {
@@ -41924,15 +41920,10 @@ async function runScriptAndRecord(options) {
     if (elapsed > recording.maxDuration) {
       console.warn(`Demo exceeded max duration (${elapsed.toFixed(1)}s > ${recording.maxDuration}s)`);
     }
-    let tracePath;
-    if (enableTrace) {
-      tracePath = (0, import_node_path.join)(outputDir, "trace.zip");
-      await context2.tracing.stop({ path: tracePath });
-    }
     await context2.close();
     const videoPath = await resolveVideoPath(outputDir);
     const duration = (Date.now() - startTime) / 1e3;
-    return { videoPath, duration, tracePath };
+    return { videoPath, duration };
   } finally {
     await browser.close();
   }
@@ -42258,8 +42249,7 @@ async function runPipeline(options) {
         path: processed.outputPath,
         format: processed.format,
         duration: recordingResult.duration,
-        sizeMB: processed.sizeMB,
-        tracePath: recordingResult.tracePath
+        sizeMB: processed.sizeMB
       },
       script,
       analysis,

packages/action/dist/index.js.map

@@ -24,7 +24,6 @@ export interface DemoResult {
     format: string;
     duration: number;
     sizeMB: number;
-    tracePath?: string;
   };
   screenshots?: string[];
   script: string;
@@ -112,7 +111,6 @@ export async function runPipeline(options: PipelineOptions): Promise<DemoResult>
         format: processed.format,
         duration: recordingResult.duration,
         sizeMB: processed.sizeMB,
-        tracePath: recordingResult.tracePath,
       },
       script,
       analysis,

packages/core/src/pipeline.ts

@@ -6,7 +6,6 @@ import type { RecordingConfig } from '../config/schema.js';
 export interface RecordingResult {
   videoPath: string;
   duration: number;
-  tracePath?: string;
 }
 
 export interface RunScriptOptions {
@@ -28,10 +27,6 @@ export async function runScriptAndRecord(options: RunScriptOptions): Promise<Rec
 
   try {
     const context = await createContext(browser, recording, outputDir);
-    const enableTrace = process.env['GG_DEBUG_TRACE'] === '1';
-    if (enableTrace) {
-      await context.tracing.start({ screenshots: true, snapshots: true, sources: false });
-    }
     const page = await context.newPage();
 
     // Inject the cursor overlay after every page load (fires after app JS/hydration
@@ -53,18 +48,12 @@ export async function runScriptAndRecord(options: RunScriptOptions): Promise<Rec
       console.warn(`Demo exceeded max duration (${elapsed.toFixed(1)}s > ${recording.maxDuration}s)`);
     }
 
-    let tracePath: string | undefined;
-    if (enableTrace) {
-      tracePath = join(outputDir, 'trace.zip');
-      await context.tracing.stop({ path: tracePath });
-    }
-
     await context.close();
 
     const videoPath = await resolveVideoPath(outputDir);
     const duration = (Date.now() - startTime) / 1000;
 
-    return { videoPath, duration, tracePath };
+    return { videoPath, duration };
   } finally {
     await browser.close();
   }