Fixes for Xcode build with artifact bundle#34
Merged
Conversation
DePasqualeOrg
temporarily deployed
to
rust-release
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Xcode 26.3 build failure reported in #33. The root cause is that
TokenizersFFIre-exports the binaryTokenizersRustmodule, which Xcode 26.3 rejects when resolving the SE-0482 artifactbundle.The fix bumps the patched UniFFI fork to a revision (shared with
swift-hf-api) that adds two Swift bindgen options to hide the lower-level FFI module from the wrapper's public interface. After regenerating the wrapper, the consumer-side workaround introduced in37f999ais no longer needed and gets reverted.CI's
test-pinnedjob now runs as a matrix across Xcode 26.3, 26.4, and 26.5, so issues like #33 surface on PRs instead of after release.